Skip to content

[18.0][ADD] server_action_mass_edit_onchange: extension to support playing onchange #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[18.0][ADD] server_action_mass_edit_onchange: extension to support playing onchange #985

merged 1 commit into from
Jun 17, 2025

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Dec 25, 2024 •
edited
Loading

@trisdoan trisdoan mentioned this pull request Dec 25, 2024
Merged
StephaneMangin
StephaneMangin approved these changes Feb 7, 2025
View reviewed changes
Copy link

@StephaneMangin StephaneMangin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legalsylvain
Copy link
Contributor

Hi could you rebase ?

ivantodorovich
ivantodorovich approved these changes Feb 10, 2025
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

ivantodorovich
ivantodorovich suggested changes Feb 10, 2025
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you rebase?

It looks like the commits of #951 are also in this PR, and they shouldn't

@trisdoan trisdoan force-pushed the 18.0-add-server_action_mass_edit_onchange branch from 46b3a93 to c00439a Compare February 11, 2025 10:50
@trisdoan
Copy link
Contributor Author

Hello @ivantodorovich, it's rebased, thanks

@legalsylvain
Copy link
Contributor

I don't get the error of the CI ...

@StefanRijnhart
Copy link
Member

@legalsylvain CI fixed in #1025

@legalsylvain
Copy link
Contributor

Thanks @StefanRijnhart. @trisdoan : could you rebase again ?

@trisdoan trisdoan force-pushed the 18.0-add-server_action_mass_edit_onchange branch from c00439a to fdc788e Compare February 12, 2025 02:36
vvrossem
vvrossem approved these changes Feb 12, 2025
View reviewed changes
server_action_mass_edit_onchange/readme/USAGE.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this file be either removed or filled with the module usage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks

@trisdoan trisdoan force-pushed the 18.0-add-server_action_mass_edit_onchange branch from fdc788e to 63bfba0 Compare February 13, 2025 02:41
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 15, 2025
@legalsylvain
Copy link
Contributor

@ivantodorovich could you update your review ?

legalsylvain
legalsylvain approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-985-by-legalsylvain-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 970bc7b into OCA:18.0 Jun 17, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6fccbd5. Thanks a lot for contributing to OCA. ❤️

@jjscarafia
Copy link

Hi @trisdoan
With this change the standard module "server_action_mass_edit" was broken. Now mass edit will only work if this new module "server_action_mass_edit_onchange" is installed

Quick video showing in runboat: https://drive.google.com/file/d/1Q5V8l2Z0aoPUvGtVd5jwb0wwGhpurPal/view

I didn't test this fix yet #1096

cc @legalsylvain @ivantodorovich

@twalter-c2c twalter-c2c mentioned this pull request Aug 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

+3 more reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@StephaneMangin StephaneMangin StephaneMangin approved these changes

@vvrossem vvrossem vvrossem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@trisdoan @legalsylvain @StefanRijnhart @OCA-git-bot @jjscarafia @ivantodorovich @StephaneMangin @vvrossem