-
Couldn't load subscription status.
- Fork 8
feat: add expression parsing and plotting helpers #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add expression parsing and plotting helpers #15
Conversation
|
@nsh07 please do check new pull request |
|
This PR looks REALLY good, the refactoring has made the code much more readable. Should I close the older PR? I think this PR contains all the changes. |
|
yeah sure ! |
|
Look, I know you put time into this, but this really isn't the kind of implementation I'm looking for. I clearly mentioned in the issue that the implementation should be similar to that of how Desmos does it. Desmos is available at https://www.desmos.com/calculator That is, there would be a button below the text field to add another text field, and you can then enter two expressions in the two text fields, and so on. Then, there would be a color selector on the left of each text field. The text fields will automatically detect the type of expression like it already does. Please implement something like I described above. Also, avoid very extensive refactoring like the code here, you can create another issue regarding code refactoring but that is out of scope for this PR. Let me know if you want to continue in this PR or create another one. |
|
Any updates? |
- Add Expression struct for managing multiple expressions with custom colors - Implement Desmos-style collapsible sidebar with numbered slots - Add dark top bar with Save button and branding - Support all expression types: regular, polar, parametric, implicit, inequalities - Add fine grid system with axis labels and zoom controls - Fix color picker positioning to prevent overlap with text inputs - Add /bigobj compiler flag for MSVC builds Resolves OPCODE-Open-Spring-Fest#15
72fcfe5 to
6a5fc8b
Compare
|
hii do check this new pr |
|
I... You didn't have to redesign the entire app into a Desmos style UI, you just had to implement the multiple expressions in a manner (workflow, if it resolves some confusion) that is similar to Desmos. Please keep changes limited to the scope of the PR you are working on! I'm mentioning this the second time. You can create another issue for a redesign, but even then I am quite against the idea of making blatant clones of existing projects. I am once again clearly mentioning what you have/had to do:
All of this can be easily implemented in a simple |
- Add Expression struct with text and color fields - Add vector of expressions with dynamic add/remove - Add color picker button next to each expression input - Render all expressions in loop with custom colors - Add Add Expression button below inputs - Add /bigobj compiler flag for MSVC Implements OPCODE-Open-Spring-Fest#15 with minimal scope changes
|
please do check the new pr @nsh07 , also i did that intially but since you said similar to desmos so i tried to keep it close enough.. |


Description
Closes #8
This PR implements support for plotting multiple mathematical expressions simultaneously, similar to Desmos functionality.
Changes Made
Features
Files Changed
src/core/Core/Expression.hpp- Expression and ExpressionManager classessrc/core/Core/Expression.cpp- Implementationsrc/core/Core/PlottingHelpers.hpp- Plotting utilities interfacesrc/core/Core/PlottingHelpers.cpp- Plotting implementationsrc/core/Core/Application.hpp- Updated to use ExpressionManagersrc/core/Core/Application.cpp- Updated UI and plotting logicsrc/core/CMakeLists.txt- Added new source filesTesting
Code of Conduct