feat(backtest): add weekly/monthly rebalancing (W/M) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayushkrtiwari PLEASE review it and if correct merge it with labels |
|
@saumya1317 please resolve the conflicts with the latest changes from main |
ayushkrtiwari
added
Type:Easy
|
@saumya1317 please resolve the conflicts so the PR could be merged. If you are facing any issues, do ask. |
- Update _should_rebalance to respect W and M frequencies - Refactor run method to use conditional rebalancing logic - Add comprehensive tests for D/W/M rebalancing - Document rebalance_freq parameter in README - All tests pass; daily default unchanged
saumya1317
force-pushed
the
feature/rebalance-frequency-WM
branch
from
32016ff to
f2211fb
Compare
ayushkrtiwari
merged commit 140ea0f
into
OPCODE-Open-Spring-Fest:main
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add weekly/monthly rebalancing options to VectorizedBacktest via
rebalance_freqparameter. This allows users to configure rebalancing frequency as "D" (daily), "W" (weekly), or "M" (monthly), addressing issue #4.Changes
_should_rebalance()method to support W/M frequenciesrun()method using proper DataFrame broadcastingTesting
pytestpasses locally (9/9 tests passing)ruff,black)Technical Details
date.weekday() == 0(Mondays)date.day == 1(1st of month)ValueErrorfor invalid frequenciesRelated Issues
Fixes #4