Stabilized v1.3.4 #109
Merged
Stabilized v1.3.4 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replaced the long if/elif menu with a clean command dispatcher (HANDLERS) and per-action handler functions. 2. Introduced dataclass ScanOptions and enums ReportType, SnapshotMode to eliminate fragile positional args and magic strings. 3. Added parse_bool, ask_choice, is_valid_domain, validate_yyyymmdd for consistent, centralized validation and UX. 4. Implemented sanitize_db_filename to prevent path traversal and enforced numeric API IDs and YYYYMMDD dates. 5. Added compute_dorking_ui_mark with mapping and safe handling of custom dorking DBs 6. Replaced custom threaded spinner with rich Console.status; removed thread race issues and simplified lifecycle. 7. Switched to time.perf_counter() for accurate duration measurement; kept time_processing for formatting. 8. Standardized paths with pathlib.Path (BASE_DIR, CONFIG_PATH, DORKING_DIR, APIS_DIR); removed hardcoded ‘//’ 9. Unified try/except Exception as e with logging.error(..., exc_info=True); fixed undefined e in except blocks 10. Safer update flow with commit/close in finally; validated input; clearer feedback; restore DB with Path and error handling. 11. Validated report ID as numeric; handled existing output folder; better error logging for report recreation. 12. Centralized startup checks. 13. Normalized Y/N handling; optional keywords parsing; consistent flags passed to data_gathering. 14. Unified mode selection via enum; validated Wayback dates; generated clear UI summary marks. 15. Preserved existing data_gathering and report creation calls while cleaning parameter preparation. 16. Reduced duplication, improved naming, early returns on invalid input, and consistent console messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.