Adress #11: Exclude trait methods from export #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trait definitions are already excluded from the export and their methods are flattened into the using classes. Exporting trait methods seperately breaks the import in VW, as the corresponding class-id is undefined. This commit a) excludes trait methods and initializers and b) changes the filter to #isClass instead of #isTrait for consistency.
|
It might be worth to consider making the exclusion of traits in general an option in the future. |
|
This PR has conflics |
|
It's been a while: Do you want to merge this PR?
|
|
Yes, ObjectProfile have used it every so often |
|
Great! I'll have a look at the conflicts. But it will take some time, as I
am quite busy at the moment.
Am .08.2019, 23:42 Uhr, schrieb Milton Mamani Torres
<notifications@github.com>:
… Yes, ObjectProfile have used it every so often
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude methods defined in traits from export
Trait definitions are already excluded from the export and their methods
are flattened into the using classes. Exporting trait methods seperately
breaks the import in VW, as the corresponding class-id is undefined.
This commit
a) excludes trait methods and initializers and
b) changes the filter to #isClass instead of #isTrait for consistency.