Skip to content

Conversation

@rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Dec 11, 2025

This PR introduces recorder structs to record preimages for transactions and receipts needed for MEL validation.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
4476 7 4469 0
View the top 3 failed tests by shortest run time
TestSetLatestSnapshotUrl
Stack Traces | 0.010s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
    init_test.go:300: running test case latest file with http url
INFO [01-06|07:08:18.237] Set latest snapshot url                  url=http://some.domain.com/arb1/2024/21/archive.tar.gz
    init_test.go:300: running test case latest file with https url
INFO [01-06|07:08:18.238] Set latest snapshot url                  url=https://some.domain.com/arb1/2024/21/archive.tar.gz
    init_test.go:300: running test case chain and contents with upper case
INFO [01-06|07:08:18.239] Set latest snapshot url                  url=http://127.0.0.1:36059/arb1/2024/21/archive.tar.gz
    init_test.go:353: goroutine 282 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x300eb70, 0xc000d02a80}, {0x2fe0f20, 0x453e4e0}, {0xc0006f8950, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/cmd/nitro.Require(0xc000d02a80, {0x2fe0f20, 0x453e4e0}, {0xc0006f8950, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/cmd/nitro/config_test.go:304 +0x5d
        github.com/offchainlabs/nitro/cmd/nitro.startFileServer.func2()
        	/home/runner/work/nitro/nitro/cmd/nitro/init_test.go:353 +0xa5
        created by github.com/offchainlabs/nitro/cmd/nitro.startFileServer in goroutine 244
        	/home/runner/work/nitro/nitro/cmd/nitro/init_test.go:350 +0x285
        
    init_test.go:353: �[31;1m [failed to shutdown server] context canceled �[0;0m
--- FAIL: TestSetLatestSnapshotUrl (0.01s)
TestRedisBatchPosterHandoff
Stack Traces | 26.510s run time
=== RUN   TestRedisBatchPosterHandoff
=== PAUSE TestRedisBatchPosterHandoff
=== CONT  TestRedisBatchPosterHandoff
    common_test.go:728: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
    batch_poster_test.go:319: Batch poster BatchPoster1 failed with unexpected error: failed to acquire lock; either another batch poster posted a batch or this node fell behind, iter: 2
--- FAIL: TestRedisBatchPosterHandoff (26.51s)
TestAnyTrustRekey
Stack Traces | 28.530s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
    anytrust_test.go:82: AnyTrust backend config created with URL: http://127.0.0.1:43583
ERROR[01-06|07:20:14.407] Error in message extractor               err="context canceled"
    common_test.go:930: goroutine 16 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x442bc30, 0xc000402700}, {0x43e80a0, 0xc11ef9ce40}, {0xc0abefb240, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/system_tests.Require(0xc000402700, {0x43e80a0, 0xc11ef9ce40}, {0xc0abefb240, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2058 +0x5d
        github.com/offchainlabs/nitro/system_tests.(*NodeBuilder).BuildL2OnL1(0xc0005f2120, 0xc000402700)
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:930 +0x5ea
        github.com/offchainlabs/nitro/system_tests.TestAnyTrustRekey(0xc000402700)
        	/home/runner/work/nitro/nitro/system_tests/anytrust_test.go:167 +0xf4a
        testing.tRunner(0xc000402700, 0x4063b80)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    common_test.go:930: �[31;1m [failed to deploy ArbDebug] nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 2 state: 3 �[0;0m
--- FAIL: TestAnyTrustRekey (28.53s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 0% with 221 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.64%. Comparing base (d216c3e) to head (f5731fd).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           raul/mel-inbox-reading    #4130      +/-   ##
==========================================================
- Coverage                   34.77%   34.64%   -0.14%     
==========================================================
  Files                         465      468       +3     
  Lines                       56343    56556     +213     
==========================================================
  Hits                        19595    19595              
- Misses                      33306    33519     +213     
  Partials                     3442     3442              

@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review December 23, 2025 13:30
@ganeshvanahalli ganeshvanahalli changed the title [MEL] - Implement a Transaction Recorder for MEL Validation [MEL] - Implement a Transaction and Receipt Recorder for MEL Validation Dec 30, 2025
@ganeshvanahalli ganeshvanahalli self-requested a review December 30, 2025 12:17
@ganeshvanahalli ganeshvanahalli changed the base branch from raul/mel-inbox-reading to master January 5, 2026 16:16
@ganeshvanahalli ganeshvanahalli changed the base branch from master to raul/mel-inbox-reading January 5, 2026 16:16
@ganeshvanahalli ganeshvanahalli changed the title [MEL] - Implement a Transaction and Receipt Recorder for MEL Validation Implement a Transaction and Receipt Recorder for MEL Validation Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants