fix: initialize PlotsquaredSupport during plugin startup #195
Conversation
Unit Test Results10 tests 10 ✅ 2s ⏱️ Results for commit 4bb34eb. ♻️ This comment has been updated with latest results. |
|
🏷️ The |
|
📦 A new JAR build is available! Note: The download link is valid for a limited time and requires GitHub authentication. |
|
@copilot Approve it if it right here :) |
|
@TheMeinerLP I've opened a new pull request, #200, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the initialization of PlotSquared support by moving the init() call from the dependency injection provider method to the plugin's onEnable() lifecycle method.
- Removed the
init()call fromExternalSupportModule.providePlotsquaredSupport() - Added explicit
init()call inAntiRedstoneClockRemastered.onEnable()after injector initialization - Added import for
PlotsquaredSupportinterface in the main plugin class
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ExternalSupportModule.java | Removed init() call from the provider method, moving initialization responsibility outside of dependency injection |
| AntiRedstoneClockRemastered.java | Added PlotsquaredSupport import and explicit init() call in onEnable() to ensure proper initialization timing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/net/onelitefeather/antiredstoneclockremastered/AntiRedstoneClockRemastered.java
Outdated
Show resolved
Hide resolved
|
📦 A new JAR build is available! Note: The download link is valid for a limited time and requires GitHub authentication. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/net/onelitefeather/antiredstoneclockremastered/AntiRedstoneClockRemastered.java
Show resolved
Hide resolved
# [2.6.0](v2.5.2...v2.6.0) (2025-11-05) ### Bug Fixes * add temporary workaround for display issue in DisplayActiveClocksCommand ([1cd213a](1cd213a)) * initialize PlotsquaredSupport during plugin startup ([b682802](b682802)) * initialize PlotsquaredSupport during plugin startup ([#195](#195)) ([a59bff9](a59bff9)) * **project:** Triggerbuild ([76e063f](76e063f)) * safely initialize PlotsquaredSupport if present during startup ([4bb34eb](4bb34eb)) * teleport in display command and add 1.21.9 + 1.21.10 for testing (remove useless <arg:4> in crowdin) ([008a34c](008a34c)) * teleport in display command and add 1.21.9 + 1.21.10 for testing… ([#192](#192)) ([0abf127](0abf127)) ### Features * add CycloneDX support and update release process for BOM generation ([ec4d7e7](ec4d7e7))
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
TheMeinerLP
moved this from 🏗 In progress
to ✅ Done
in AntiRedstoneClock-Remastered Roadmap
Proposed changes
Fixes order of plotsquared initialization of plot flag. Previously, the flag was being set before plotsquared was fully initialized, causing it to not work as intended.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...