Skip to content

Conversation

camrrx
Copy link
Member

@camrrx camrrx commented Oct 8, 2025

Proposed changes

  • Add a new endpoint, GET /api/endpoints/targets/, to retrieve all endpoints, including those in dynamic asset groups.
  • correct the inject isReady to take into account array of value in mandatoryConditionValues

Testing Instructions

  1. Create an atomic testing with a contract nuclei or nmap
  2. Choose an asset group
  3. Execute
  4. Check execution traces: It would be smt like:
Screenshot 2025-10-14 102414

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 70.14925% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.94%. Comparing base (30fd454) to head (713ba15).
⚠️ Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
...o/openaev/execution/ExecutableInjectDTOMapper.java 0.00% 11 Missing ⚠️
...i/src/main/java/io/openaev/executors/Executor.java 0.00% 3 Missing ⚠️
.../main/java/io/openaev/service/EndpointService.java 91.89% 2 Missing and 1 partial ⚠️
...n/java/io/openaev/utils/mapper/EndpointMapper.java 80.00% 1 Missing and 1 partial ⚠️
...ava/io/openaev/rest/asset_group/AssetGroupApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4169      +/-   ##
=====================================================
+ Coverage              48.86%   48.94%   +0.07%     
- Complexity              3467     3485      +18     
=====================================================
  Files                    874      875       +1     
  Lines                  25966    26030      +64     
  Branches                1932     1936       +4     
=====================================================
+ Hits                   12689    12740      +51     
- Misses                 12518    12528      +10     
- Partials                 759      762       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 9, 2025
@savacano28 savacano28 changed the title [frontend] Allow array in visible field [backend/frontend] Allow nmap and nuclei support asset groups Oct 9, 2025
@savacano28 savacano28 changed the title [backend/frontend] Allow nmap and nuclei support asset groups [backend/frontend] Add enpoint to fetch for nuclei and nmap injectors Oct 9, 2025
@camrrx camrrx marked this pull request as ready for review October 14, 2025 13:45
@MarineLeM MarineLeM linked an issue Oct 14, 2025 that may be closed by this pull request
@heditar heditar self-requested a review October 14, 2025 15:08
@EvaE-Filigran
Copy link
Contributor

Test local ok !

@MarineLeM MarineLeM merged commit f18e90d into release/current Oct 15, 2025
10 checks passed
@MarineLeM MarineLeM deleted the issue/front-4165 branch October 15, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team multirepository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow nmap & nuclei injectors to support asset groups

5 participants