Skip to content

Conversation

welandaz
Copy link
Contributor

@welandaz welandaz commented Jan 14, 2025

This work resolves the following issue - #18384

Integration tests have been executed manually according to the contribution guidelines.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@welandaz welandaz changed the title Address [rawtypes] and [this-escape] warnings in generated API clients [Java] Address [rawtypes] and [this-escape] warnings in generated API clients Jan 14, 2025
@welandaz welandaz changed the title [Java] Address [rawtypes] and [this-escape] warnings in generated API clients [JAVA] Address [rawtypes] and [this-escape] warnings in generated API clients Jan 14, 2025
@wing328
Copy link
Member

wing328 commented Jan 14, 2025

thanks for the PR

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

}

protected String getDefaultBaseUri() {
private String getDefaultBaseUri() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally i'm ok with the PR but if later users have a use case that need protected method here for example, we will need to provide a way to fallback.

@wing328 wing328 added this to the 7.11.0 milestone Jan 18, 2025
@wing328 wing328 merged commit fa3e38a into OpenAPITools:master Jan 18, 2025
89 checks passed
@welandaz welandaz deleted the welandaz/apiclient-deprecations branch January 20, 2025 21:22
timon-sbr pushed a commit to timon-sbr/openapi-generator that referenced this pull request Mar 13, 2025
… clients (OpenAPITools#20466)

* Address [rawtypes] and [this-escape] warnings in generated API clients

* Commit updated sample files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants