Skip to content

Conversation

thetric
Copy link
Contributor

@thetric thetric commented Jan 23, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Should fix #18753

@thetric
Copy link
Contributor Author

thetric commented Jan 23, 2025

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@thetric
Copy link
Contributor Author

thetric commented Jan 23, 2025

Hm, samples/client/petstore/java-micronaut-client fails because it does not seem to be using Jackson 2.18. But the latest Micronaut 3.x version only comes with Jackson 2.15. Upgrading to Micronaut 4 would require an upgrade to Jakarta EE and a Java 17 baseline

@martin-mfg
Copy link
Contributor

Hi @thetric, thanks for the PR!

According to the docs, the default behaviour of ThreeTenTimeModule differs from ThreeTenModule. Did you check if this is a problem in the changed files and we need to adapt?

Regarding the failing node0 test: I think this test shouldn't be affected at all by your changes. So I was confused why it fails here and simply ran the test again. see martin-mfg#62. I didn't make any changes to the code from this PR, and still the node0 test succeeded. So I think simply re-triggering the tests in your PR (e.g. by rebasing your branch on the latest master) should solve the problem.

@wing328 wing328 merged commit 6f19741 into OpenAPITools:master Feb 9, 2025
16 checks passed
@wing328 wing328 added this to the 7.12.0 milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants