Skip to content

Conversation

martin-mfg
Copy link
Contributor

These are the changes from #19925, by @beikov. I just rebased those changes on the current master branch and re-built all samples, as requested in #19925 (comment).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Mar 3, 2025

            .defaultDateFormat(new RFC3339DateFormat())
            .addModule(new JavaTimeModule())
            .addModule(new JsonNullableModule())
            .addModule(new RFC3339JavaTimeModule())

what's the difference between JavaTimeModule and RFC3339JavaTimeModule?

do we need both?

@wing328
Copy link
Member

wing328 commented Mar 3, 2025

cc @beikov

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328 wing328 added this to the 7.13.0 milestone Mar 3, 2025
@wing328 wing328 removed this from the 7.13.0 milestone Mar 3, 2025
@beikov
Copy link
Contributor

beikov commented Mar 3, 2025

The JavaTimeModule is the Jackson provided module which will add support for all sorts of java.time types, whereas the RFC3339JavaTimeModule is specifically about overriding the Instant, OffsetDateTime and ZonedDateTime deserializers in a way that supports full RFC3339 format and not just ISO8601.

@wing328
Copy link
Member

wing328 commented Mar 3, 2025

👌

thanks for the explanation.

let's give it a try

@wing328 wing328 merged commit 2b8d496 into OpenAPITools:master Mar 3, 2025
109 checks passed
@wing328 wing328 added this to the 7.13.0 milestone Mar 3, 2025
kpy3 pushed a commit to kpy3/openapi-generator that referenced this pull request Mar 13, 2025
…time types, regenerate samples (OpenAPITools#20700)

Co-authored-by: Christian Beikov <christian.beikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants