Skip to content

Conversation

sabra
Copy link
Contributor

@sabra sabra commented Feb 27, 2025

Added possibility to generate restclient and webclient as a @Component in the same fashion as resttemplate.

Fix #17885
Fix #19229

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sabra sabra force-pushed the fix/rest-client-missing-component-option branch 2 times, most recently from a8f4c8f to 562c36a Compare February 27, 2025 23:48
Added possibility to generate restclient and webclient as a @component in the same fashion as resttemplate.

Fix OpenAPITools#17885
Fix OpenAPITools#19229
@sabra sabra force-pushed the fix/rest-client-missing-component-option branch from 562c36a to ae9c13b Compare March 1, 2025 19:03
@sabra
Copy link
Contributor Author

sabra commented Mar 4, 2025

@wing328 could you please approve rest of the workflows that are waiting for approval? Thank you

@wing328 wing328 added this to the 7.13.0 milestone Mar 5, 2025
@wing328
Copy link
Member

wing328 commented Mar 5, 2025

tested the option locally and the result is good

thanks for the enhancement

@wing328 wing328 merged commit f2bbb9e into OpenAPITools:master Mar 5, 2025
104 checks passed
@sabra
Copy link
Contributor Author

sabra commented Mar 5, 2025

Thank you for merging 😉

kpy3 pushed a commit to kpy3/openapi-generator that referenced this pull request Mar 13, 2025
…s#20754)

* [java] generateClientAsBean for restclient and webclient

Added possibility to generate restclient and webclient as a @component in the same fashion as resttemplate.

Fix OpenAPITools#17885
Fix OpenAPITools#19229

* - Samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [JAVA] Generate Client As Bean for WebClient/RestClient [BUG][JAVA][WebClient] Removal of @Component from ApiClient

2 participants