-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[cpprestsdk] Support passing enum request parameters #20836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A better way to fix: #10301 |
Without this PR, using enums as HTTP GET request parameters, errors will occur when compiling the source code generated by cpprestsdk. Anyone please take a look. |
thanks for the PR what about add a fake endpoint to modules/openapi-generator/src/test/resources/3_0/cpp-restsdk/petstore.yaml to test enum request parameters and update the samples (step 3 in PR checklist, make sure to run the command twice) ? |
@wing328 PTAL |
please update |
Done. PTAL again, thx. @wing328 |
https://github.com/OpenAPITools/openapi-generator/actions/runs/14703025058/job/41259693532?pr=20836 please update the samples again to fix the above error |
Done. Up to date with master. @wing328 |
tested locally and the result is good
|
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd