Skip to content

Conversation

AB-xdev
Copy link
Contributor

@AB-xdev AB-xdev commented May 9, 2025

Fixes #21250

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

Fun Fact: You could create a GitHub team for that so that I don't have to mention everyone separately

@AB-xdev AB-xdev marked this pull request as ready for review May 9, 2025 12:37
@wing328 wing328 added this to the 7.14.0 milestone May 11, 2025
@wing328 wing328 merged commit 57bf692 into OpenAPITools:master May 11, 2025
123 checks passed
@AB-xdev AB-xdev deleted the 21250-make-java-apiclient-extendable branch May 12, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [Java] Make it possible to extend ApiClient completely
2 participants