[Bug][java-spring] Use Flux only for multipart-form-data file parameters with multiple file uploads #21561
+81
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21559
This change fixes the parameter type used for multipart-form-data file uploads when generating code with the Java Spring OpenAPI generator with Spring WebFlux (reactive).
The current generator is using the parameter type of
Flux<Part>
for specs with single file uploads, andList<Flux<Part>>
for specs with multiple file uploads. For more details see #21559This PR changes the Java Spring templates to generating code with
Part
for single file uploads, orFlux<Part>
for multi file uploads. A new unit test was added toSpringCodegenTest.java
to test that the parameter type is correct for single & multi file upload parameters with Spring WebFlux.There has been some recent prior work around multipart-form-data file uploads for non-reactive Spring servers, such as #21524, #21465
The prior PR to address multipart-form-data file uploads for reactive Spring was #6993
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)Java Spring: @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)
Prior work on multipart-form-data file uploads for Java Spring: @wing328 @SidWagz @bit-factor