Skip to content

Conversation

rgroothuijsen
Copy link
Contributor

When oneOf is specified with multiple types of array, Rust will not compile the resulting code because each enum option is named Array. This change extends the name of each type with its container type and inner data type, creating names such as ArrayVeci32 and ArrayVecString unless the user explicitly specifies another name using the title field.

Fixes #18527

@jacob-pro

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jul 21, 2025

thanks for the pr

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)

@wing328
Copy link
Member

wing328 commented Aug 7, 2025

tested locally to confirm the fix

--- a/src/models/option1_or_option2_options.rs
+++ b/src/models/option1_or_option2_options.rs
@@ -14,13 +14,13 @@ use serde::{Deserialize, Serialize};
 #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
 #[serde(untagged)]
 pub enum Option1OrOption2Options {
-    Array(Vec<String>),
-    Array(Vec<i32>),
+    ArrayVecString(Vec<String>),
+    ArrayVeci32(Vec<i32>),
 }

 impl Default for Option1OrOption2Options {
     fn default() -> Self {
-        Self::Array(Default::default())
+        Self::ArrayVecString(Default::default())
     }
 }

let's give it (bug fix) a try

if someone needs the old way to name the enum option, we can add an option to do so for fallback

@wing328 wing328 merged commit 603dbfd into OpenAPITools:master Aug 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][RUST] oneOf with multiple arrays produces invalid rust code
2 participants