-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Kotlin Multiplatform polymorphism with custom discriminator support #21772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Kotlin Multiplatform polymorphism with custom discriminator support #21772
Conversation
please review the build failure when you've time |
@wing328 thanks, fixed the issue. At least my local |
what about https://github.com/OpenAPITools/openapi-generator/actions/runs/17288142203/job/49073090200?pr=21772? is it caused by this PR? |
@wing328 yes it was caused by this PR, but said |
ok found the problem. I named the sample project While I think it should be Should I follow existing convention or use |
related: #14301, #21531
This is essentially a successor of #21531.
I've added discriminator support for kotlin-client multiplatform, as asked in https://github.com/OpenAPITools/openapi-generator/pull/21531/files?w=1#r2276511440.
KotlinClientCodegen#postProcessAllModels(Map)
kotlin-multiplatform-allOf-discriminator
@dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)