Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Sep 6, 2025

based on #20006

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title Lbialy scala sttp4 jsoniter New generator for Scala3 + sttp4 + jsoniter-scala #20006 Sep 6, 2025
@wing328 wing328 added this to the 7.16.0 milestone Sep 6, 2025
@wing328 wing328 marked this pull request as ready for review September 6, 2025 05:19
}

// below code block only for scala-sttp4-jsoniter for backward copmatibility
if (this instanceof ScalaSttp4JsoniterClientCodegen) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbialy

fyi. i added this check for backward compatibility (otherwise it would break scala-akka tests)

cc @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06)

@wing328 wing328 changed the title New generator for Scala3 + sttp4 + jsoniter-scala #20006 New generator for Scala3 + sttp4 + jsoniter-scala Sep 6, 2025
@wing328 wing328 merged commit 1d739f1 into master Sep 6, 2025
27 of 28 checks passed
@wing328 wing328 deleted the lbialy-scala-sttp4-jsoniter branch September 6, 2025 05:36
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
* started impl

* seems to work

* generated docs

* fix class name duplicates on case-insensitive filesystems

* wip

* added script to rebuild all projects

* dropped bash slop

* fixed directory structure

* ok, now it makes sense

* update sttp, serialize query params, fix enums serialization, fix not required files params

* fix compile errors after sttp upgrade, fix missing enum import in operations, fix file response. change serialization from Map to Seq to avoid deleting duplicate keys

* auth support

* fix enums entries, multipart support(partially), header, path and cookie serialization support

* support of option fields

* add samples, update workflow

* add new files

* fix

* remove tab

* remove tab

* update doc

* update header

* update readme

---------

Co-authored-by: Łukasz Biały <lukasz.marcin.bialy@gmail.com>
Co-authored-by: Kamil-Lontkowski <kamillont14@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants