Skip to content

Conversation

Mattias-Sehlstedt
Copy link
Contributor

Issue #21799 fixed how the parent is calculated for a model. This can cause issues when using the REF_AS_PARENT_IN_ALLOF normalization setting in order to achieve inheritance in the generated code. See issue #22043 for a discussion on how the issue presents itself.

This PR adds a test to illustrate the issue, and with it also a possible fallback that can be used to achieve the old behavior.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Mattias-Sehlstedt Mattias-Sehlstedt changed the title Add illustration of how to handle x-parent without REF_AS_PARENT_IN_ALLOF normalization [Test] [Java] Add test example of how to handle x-parent without REF_AS_PARENT_IN_ALLOF normalization Oct 5, 2025
@wing328 wing328 merged commit 4352a2f into OpenAPITools:master Oct 6, 2025
14 checks passed
@wing328 wing328 added this to the 7.17.0 milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants