[Aerospace Sparta] Add sparta connector verified #5116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient_api and connector files
Ninoxe
requested review from
Kakudou,
Powlinett,
helene-nguyen,
mariot and
pdamoune
Ninoxe
added
filigran team
|
If the connector is considered as "Verified" after this PR, the manifest has to be updated also to include it in the composer |
mariot
requested changes
Oct 31, 2025
| #send_to_directory_path: 'ChangeMe' # if CONNECTOR_SEND_TO_DIRECTORY is True, you must specify a path | ||
| #send_to_directory_retention: ChangeMe # Default: 7, in days | ||
| #name: 'Aerospace SPARTA' | ||
| #scope: '["attack-pattern", "course-of-action", "indicator", "identity"]' |
There was a problem hiding this comment.
Suggested change
| #scope: '["attack-pattern", "course-of-action", "indicator", "identity"]' | |
| scope: 'attack-pattern, course-of-action, indicator, identity' |
Comment on lines
+38
to
+48
| class ConfigLoader(ConfigBaseSettings): | ||
| """Interface for loading global configuration settings.""" | ||
|
|
||
| opencti: _ConfigLoaderOCTI = Field( | ||
| default_factory=_ConfigLoaderOCTI, | ||
| description="OpenCTI configurations.", | ||
| ) | ||
| connector: ConfigLoaderConnector = Field( | ||
| default_factory=ConfigLoaderConnector, | ||
| description="Connector configurations.", | ||
| ) |
There was a problem hiding this comment.
Should we use the connectors-sdk?
Comment on lines
+66
to
+89
| if env_path.exists(): | ||
| return ( | ||
| DotEnvSettingsSource( | ||
| settings_cls, | ||
| env_file=env_path, | ||
| env_ignore_empty=True, | ||
| env_file_encoding="utf-8", | ||
| ), | ||
| ) | ||
| elif yaml_path.exists(): | ||
| return ( | ||
| YamlConfigSettingsSource( | ||
| settings_cls, | ||
| yaml_file=yaml_path, | ||
| yaml_file_encoding="utf-8", | ||
| ), | ||
| ) | ||
| else: | ||
| return ( | ||
| EnvSettingsSource( | ||
| settings_cls, | ||
| env_ignore_empty=True, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Our default order is:
- Environment variables
- YAML file
- .env file
- Default values
But implementing this might cause a breaking change for the client. How should we proceed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
To do after review:
Related issues
Checklist