Update xmlseclibs to version 3.1.4 #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, it was possible to use a version of xmlseclibs that contained security issues.
Prior to this change, this library could be installed alongside symfony/http-foundation 8. However, this library will break with http-foundation 8, as the generic get() function from the request method is removed. See \Surfnet\SamlBundle\SAML2\AuthnRequestFactory::createSignedFromHttpRequest See \Surfnet\SamlBundle\SAML2\AuthnRequestFactory::createAuthnRequestFromHttpRequest
johanib
force-pushed
the
feature/xmlseclibsupdate
branch
from
5f22c71 to
db168a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require xmlseclibs 3.1.4
Prior to this change, it was possible to use a version of xmlseclibs that contained security issues.
Mark bundle as incompatible with SF 8
Saml Bundle is not compatible with symfony/http-foundation yet
Prior to this change, this library could be installed alongside symfony/http-foundation 8.
However, this library will break with http-foundation 8, as the generic get() function from the request method is removed.
Split into issue: #135
See \Surfnet\SamlBundle\SAML2\AuthnRequestFactory::createSignedFromHttpRequest
See \Surfnet\SamlBundle\SAML2\AuthnRequestFactory::createAuthnRequestFromHttpRequest