[PATCH v5] api: event_vector: small clarifications and additions #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
Contributor
|
Acked-by: Pavan Nikhilesh pbhagavatula@marvell.com |
PavanNikhilesh
approved these changes
Dec 15, 2025
JannePeltonen
approved these changes
Dec 15, 2025
MatiasElo
force-pushed
the
dev/api-event-vector
branch
from
81d1d70 to
e3fc800
Compare
odpbuild
changed the title
MatiasElo
force-pushed
the
dev/api-event-vector
branch
from
e3fc800 to
55a1ff8
Compare
odpbuild
changed the title
TuomasTaipale
approved these changes
Dec 19, 2025
MatiasElo
force-pushed
the
dev/api-event-vector
branch
from
55a1ff8 to
e97033e
Compare
odpbuild
changed the title
MatiasElo
added
the
API Ready
Clarify that event aggregation is performed automatically for incoming packets when aggregation is enabled in packet input queue parameters. Also, clarify that odp_pktin_event_queue() returns always base input queue handles, not aggregator handles. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Clarify that event aggregation is performed automatically for classified packets when aggregation is enabled in CoS parameters. Also, clarify that in this case classifier accessor functions still return base queue handles, not aggregator handles. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Add new 'type' and 'aggr_config' fields to odp_queue_info_t and document struct contents better for event aggregator queues. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Remove old event aggregator specific odp_queue_info() validation tests to prepare for updated API specification. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Update odp_queue_info() implementation to follow the updated API specification. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Test that odp_pktin_event_queue() still returns normal queue handles when event aggregation is enabled. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Update odp_queue_info() validation tests to follow the updated API specification. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
MatiasElo
force-pushed
the
dev/api-event-vector
branch
from
e97033e to
0e2e224
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2: