[PATCH v6] api: crypto: add snow5g algorithm #2293
Conversation
odpbuild
changed the title
| * NEA4 & NIA4 specification: | ||
| * COUNT || BEARER || DIRECTION || 0...0 | ||
| */ | ||
| ODP_CIPHER_ALG_SNOW5G_NEA4, |
There was a problem hiding this comment.
I wonder if this naming style (i.e. SNOW5G_NEA4, instead of just SNOW5G or just NEA4) is what we want to do. I am not sure what to think of it.
I know some existing API definitions use that style but it has already lead to some weirdnesses such as having both ODP_CIPHER_ALG_AES_EEA2 and ODP_CIPHER_ALG_AES_CTR, which are actually the same thing (for 128-bit keys). Then there is also the issue that 3GPP names the same underlying algorithm with different names depending on the release (e.g. UEA2, EEA1 and NEA1 are identical from ODP perspective, AFAIK).
There was a problem hiding this comment.
So can we use ODP_CIPHER_ALG_NEA4 and ODP_AUTH_ALG_NIA4 ?
There was a problem hiding this comment.
We can also keep the proposed name and leave possible renaming of the algorithms (not just this one) for better consistency for future.
| * COUNT || BEARER || DIRECTION || 0...0 | ||
| */ | ||
| ODP_CIPHER_ALG_SNOW5G_NEA4, | ||
|
|
There was a problem hiding this comment.
If NEA4 and NIA4 are being added, then maybe it would be good to add NCA4 too?
There was a problem hiding this comment.
.Does not have to be in this PR.
odpbuild
changed the title
nkaithakadan
force-pushed
the
snow5g_spec
branch
from
9767685 to
7c12b44
Compare
odpbuild
changed the title
nkaithakadan
force-pushed
the
snow5g_spec
branch
from
7c12b44 to
b2b3697
Compare
odpbuild
changed the title
|
@nkaithakadan, please add Janne's reviewed-by tags to the PR. |
nkaithakadan
force-pushed
the
snow5g_spec
branch
from
b2b3697 to
c8cf200
Compare
odpbuild
changed the title
Done. |
MatiasElo
added
the
API Ready
Add SNOW5G cipher and integrity algorithms. Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com>
MatiasElo
force-pushed
the
snow5g_spec
branch
from
c8cf200 to
514d08f
Compare
odpbuild
changed the title
3 participants
Add SNOW5G cipher and integrity algorithms.