Split VORTEXM4 from VORTEX target and fix SGEMM_DIRECT support for SME-capable targets #5423
+359
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reserved on MacOS
…ang compatibility
…t_performant for ARM64
matcraje
reviewed
Aug 20, 2025
| #define C6 x22 //Constant6: N*SVLs | ||
| #define C2 x19 //Constant2: N + SVLs | ||
| #define C3 x20 //Constant3: K*SVLs + SVLs | ||
| #define C4 x21 //Constant4: SVLs-2 |
Contributor
There was a problem hiding this comment.
Modifying x20 to x21 will require below dependent changes.
At line 65: sub w21, w21, #2
At line 202: cmp w13, w21
Collaborator
Author
There was a problem hiding this comment.
Oops, sorry, I had already corrected this locally but pushed the wrong version. Unfortunately this correction has no effect on the wrong xscblat3 test results seen for M odd (and contrary to my expectations this PR also does not fix the divergence between SGEMM and SGEMMT seen in test_sgemmt of utest/openblas_utest_ext that was flagged in #5414)
…t support it w/out SVE)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventually fixes #5414