Skip to content

Pull from main #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 273 commits into from
Jun 7, 2024
Merged

Pull from main #2

merged 273 commits into from
Jun 7, 2024

Conversation

@tomast1337
Copy link
Member

No description provided.

tomast1337 and others added 30 commits May 24, 2024 22:24
@tomast1337 @Bentroen
Add song validation constants
e3569fe 
Co-authored-by: Bentroen <29354120+Bentroen@users.noreply.github.com>
@tomast1337
Add getEditSong and patchSong methods to SongController
4c8b44e
@tomast1337
Update dependencies in pnpm-lock.yaml
e650bb8
@tomast1337
Add new types for visibility, category, and license
e30baa9
@tomast1337
Add type imports and update visibility and category types in UploadSo…
fd44849 
…ngDto
@tomast1337
Remove categoriesList from song validation
e2307a9
@tomast1337
Add categories, licenses, and visibility options to song constants
33d1ddf
@tomast1337
Add loadSong function to EditSongProvider context
0d5e0a3
@tomast1337
Add SongEditForm component
e1a801e
@tomast1337
Add song data fetching and display in EditSongPage
c2f53bb
@tomast1337
Add enum validation for visibility, licenses, and categories in SongF…
a6f7dcc 
…ormSchema
@tomast1337
Refactor SongForm component to use constants for categories, visibili…
75a5a72 
…ty, and licenses
@Bentroen
chore: replace Express package with express
2dc49e0
@tomast1337
Refactor song validation constants to use deep freeze
55601b5
@tomast1337
Refactor enum types in uploadSongForm.zod.ts
c95e7c9
@tomast1337
Refactor EditSong.context.tsx to use UploadSongDtoType
b8e3817
@tomast1337
Refactor SongEditForm and SongEditPages components
bc29261
@tomast1337 @Bentroen
Update song entity and related files
8ac8f8d 
Co-authored-by: Bernardo Costa <Bentroen@users.noreply.github.com>
@tomast1337
Remove unused type declaration in CoverData.dto.ts
3628ad0
@tomast1337
Add category, coverData, license, and customInstruments to UploadSongDto
94227bd
@tomast1337
Refactor imports in song.service.ts
052a18b
@tomast1337 @Bentroen
Update song edit pages and song entity***
7917aff 
***Add ThumbnailData DTO and update UploadSongResponseDto and UploadSongDto

Co-authored-by: Bentroen <29354120+Bentroen@users.noreply.github.com>
Co-authored-by: Bentroen <bemcdc@gmail.com>
Co-authored-by: Bernardo Costa <bemcdc@gmail.com>
@tomast1337
Fix cookie deletion in login.util.ts
a25b60c
@tomast1337
Comment out console.log statements in HomePageProvider
185271d
@tomast1337
Remove console.log statement and fix pagination state
a1dbe8a
@tomast1337
Refactor SongEditPages component to include user data
95a3fd7
@tomast1337
Update visibility enum in SongFormSchema
59125d2
@tomast1337 @Bentroen
Refactor spited processUploadedSong method into smaller methods
06b74e9 
Co-authored-by: Bentroen <29354120+Bentroen@users.noreply.github.com>
Co-authored-by: Bentroen <bemcdc@gmail.com>
Co-authored-by: Bernardo Costa <bemcdc@gmail.com>
@tomast1337 @Bentroen
Refactor UploadSongDto validation constants
197d6f9 
Co-authored-by: Bentroen <29354120+Bentroen@users.noreply.github.com>
Co-authored-by: Bentroen <bemcdc@gmail.com>
Co-authored-by: Bernardo Costa <bemcdc@gmail.com>
@tomast1337
Comment out console.log statement in InstrumentPicker.tsx
ced64d7
Bentroen added 28 commits June 7, 2024 02:54
@Bentroen
feat: add file display and song download button to edit page
260b35f
@Bentroen
refactor: rename UploadSong to UploadSongPage
16be222 
For consistency with the edit page
@Bentroen
refactor: move upload/edit page styles down into component from `page…
973463b 
….tsx`
@Bentroen
fix: improve typography and truncate edit song page title
2080d7d
@Bentroen
fix: remove extra shadow in user popover menu
4fd2466 
The popover component has already got a shadow, duh!
@Bentroen
fix: prevent menu border disappearing due to clashing shadows
5b39efd 
- Improve menu appearance, padding and offsets
@Bentroen
feat: implement skeleton loading for homepage songs
d0fe33c
@Bentroen
fix: adapt card size to max row height + clamp title to two lines
e653f1c
@Bentroen
fix: unnecessary href fallback
0753d83
@Bentroen
fix: properly create skeleton loading components on load
98bd5f7
@Bentroen
fix: pass initial unloaded songs from server for skeleton loading
ccf4b71
@Bentroen
fix: enable thumbnail image optimization again
5b76487
@Bentroen
fix: make card height fixed again
8f1c800
@Bentroen
fix: make carousel wrap around instead of looping
52307ec
@Bentroen
fix: implement server fetching again on homepage songs
5e017cd
@Bentroen
fix: prevent skeleton loading from appearing in empty table rows
d22b3eb
@Bentroen
improvement: rename 'Created at' table column to 'Uploaded at'
f69368c
@Bentroen
improvement: decrease opacity of disabled footer paging button
d143b1c
@Bentroen
refactor: replace form numeric limits with constants from shared module
fcd59cb
@Bentroen
fix: carousel div overflow breaking page layout
ce984b3
@Bentroen
fix: prevent trailing lines on transform animations
c5ce14a
@Bentroen
chore: update eslint configuration to policy blank lines
b424bc1 
- Add linting to shared/ package
@Bentroen
chore: add lint command to shared/ package and command to lint all mo…
23e4ff3 
…dules
@Bentroen
chore: update eslint formatter config
59fd651
@Bentroen
chore: disable warning due to use of require()
37c2a6e
@Bentroen
chore: apply blank line linting rules
f3c9e17
@Bentroen
chore: add linting fix commit to .git-blame-ignore-revs
629412f
@Bentroen
Merge branch 'song-create-and-edit-fixes'
184df24
@tomast1337 tomast1337 merged commit b32cc66 into cypress Jun 7, 2024
@Bentroen Bentroen mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomast1337 @Bentroen