Skip to content

image-zoom.c: add the xsize and ysize check to zero in _cupsImageZoomNew #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

image-zoom.c: add the xsize and ysize check to zero in _cupsImageZoomNew #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cupsfilters/image-zoom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ _cupsImageZoomNew(
if (xsize > CUPS_IMAGE_MAX_WIDTH ||
ysize > CUPS_IMAGE_MAX_HEIGHT ||
(xc1 - xc0) > CUPS_IMAGE_MAX_WIDTH ||
(yc1 - yc0) > CUPS_IMAGE_MAX_HEIGHT)
return (NULL); /* Protect against integer overflow */
(yc1 - yc0) > CUPS_IMAGE_MAX_HEIGHT ||
xsize == 0 || ysize == 0)
return (NULL); /* Protect against integer overflow and divide by zero */

if ((z = (cups_izoom_t *)calloc(1, sizeof(cups_izoom_t))) == NULL)
return (NULL);
Expand Down
2 changes: 2 additions & 0 deletions filter/imagetoraster.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,6 +1437,8 @@ main(int argc, /* I - Number of command-line arguments */
z = _cupsImageZoomNew(img, xc0, yc0, xc1, yc1, xtemp, ytemp,
Orientation & 1, zoom_type);

if (z == NULL) continue;

/*
* Write leading blank space as needed...
*/
Expand Down