Skip to content

Conversation

@sroopsai
Copy link
Contributor

@sroopsai sroopsai commented Apr 1, 2019

  1. Converted README to long_description
  2. Replaced version='?' with version='1.7.4+1.0.0'
  3. Switched from distutils.core to setuptools to avoid Userwarning long_description_content_type not available.

@sroopsai
Copy link
Contributor Author

sroopsai commented Apr 1, 2019

AttributeError: 'PosixPath' object has no attribute 'read_text'
using Python 3.4 because pathlib.Path.read_text is introduced in Python 3.5. Should think an alternative

@codecov-io
Copy link

Codecov Report

Merging #70 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #70   +/-   ##
========================================
  Coverage    62.09%   62.09%           
========================================
  Files            7        7           
  Lines         1385     1385           
========================================
  Hits           860      860           
  Misses         525      525

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11f835...7046991. Read the comment docs.

import pathlib

version = '?'
version = '1.7.4+1.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a version here is not good since I don't want to manually update it here. This is currently injectsed like this:
https://github.com/OpenRoberta/robertalab-ev3dev/blob/develop/debian/rules#L12

maybe it would be better to use None as a default and fail if it not importable from the environment.

@ensonic
Copy link
Contributor

ensonic commented Jun 6, 2019

Sorry, I completely missed PR. Thanks for updating this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants