fix: Retry updates #141
Merged
fix: Retry updates #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNeshi
commented
Oct 28, 2025
| where | ||
| F: Fn() -> Fut, | ||
| Fut: Future<Output = Result<T, RobustProviderError>>, | ||
| Fut: Future<Output = Result<T, RpcError<TransportErrorKind>>>, |
Collaborator
Author
There was a problem hiding this comment.
Reverting the change asked for in #135 (comment).
Why? Since we know we're working only with alloys providers, it is safe to specify the RpcError as the expected one for all operations.
0xNeshi
commented
Oct 28, 2025
Comment on lines
-282
to
+263
| Err::<i32, RobustProviderError>(RobustProviderError::Timeout) | ||
| Err(TransportErrorKind::BackendGone.into()) |
Collaborator
Author
There was a problem hiding this comment.
Presumably Error::Timeout was returned for simplicity, but to avoid future confusion about this retry... timing out, better for the inner error to be something else.
0xNeshi
commented
Oct 28, 2025
Comment on lines
-49
to
+50
| #[error("Retry failed after {0} tries")] | ||
| RetryFail(usize), | ||
| #[error("RPC call failed after exhausting all retry attempts: {0}")] | ||
| RetryFailure(Arc<RpcError<TransportErrorKind>>), |
Collaborator
Author
There was a problem hiding this comment.
It should be safe to assume that the lib user already knows the max retry count, so we should only notify them that retries have failed and with what error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #112