Add Match test #51
Merged
Add Match test #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanjpro
reviewed
Dec 6, 2024
Contributor
|
You should cleanup the TempDir, that you have created after the test has run |
juanli16
requested changes
Dec 9, 2024
pkg/pair/match_test.go
Outdated
| csvReader := csv.NewReader(f) | ||
| records, err := csvReader.ReadAll() | ||
| require.NoError(t, err, "must read csv data") | ||
| require.Len(t, records, 800, "must contain 100 emails") |
Contributor
There was a problem hiding this comment.
Suggested change
| require.Len(t, records, 800, "must contain 100 emails") | |
| require.Len(t, records, 800, "must contain 800 emails") |
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
const (
commonStart int 100
commonEnd int 900
nEmails int 1001
)
Contributor
There was a problem hiding this comment.
please use some constants instead
Comment on lines
+68
to
+69
| _, exists := expectContain[line[0]] | ||
| require.True(t, exists, "must exist in the hash-encrypted list") |
Contributor
There was a problem hiding this comment.
Suggested change
| _, exists := expectContain[line[0]] | |
| require.True(t, exists, "must exist in the hash-encrypted list") | |
| _, exists := expectContain[line[0]] | |
| require.True(t, exists, "must exist in the hash-encrypted list") | |
| delete(expectContain, line[0]) |
Contributor
There was a problem hiding this comment.
You don't want the same ID matching over and over again.
Comment on lines
+132
to
+133
| _, exists := expectContain[line[0]] | ||
| require.True(t, exists, "must exist in the hash-encrypted list") |
Contributor
There was a problem hiding this comment.
Suggested change
| _, exists := expectContain[line[0]] | |
| require.True(t, exists, "must exist in the hash-encrypted list") | |
| _, exists := expectContain[line[0]] | |
| require.True(t, exists, "must exist in the hash-encrypted list") | |
| delete(expectContain, line[0]) |
juanli16
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.