Fix writing dense nodes version #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidKarlas
force-pushed
the
fixWritingPbfVersion
branch
from
da48e17 to
84fa0aa
Compare
|
I wanted to use new AssertEqual helpers for everything but some existing tests have hardcoded values to test against and not SourceObject values... so I gave up on that... Left helpers for Ways and Relations there if someone wants in future to use them... |
|
@xivk any chance this could be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking around trying to see how hard it would be to support .Visible property I noticed that DenseNodes are delta encoding version, which they shouldn't...
Hence made fix and unit test...