Add support for callhome to RNC application

[Tobianas]

Add support for callhome in RNC application as described in lighty-netconf-sb README file. To use callhome, user still needs to add odl-netconf-callhome-server.

[gemini-code-assist]

Summary of Changes

Hello @Tobianas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for NETCONF callhome functionality into the RNC application. The changes enable the RNC module to initiate connections back to a NETCONF server, enhancing its network management capabilities by allowing devices to 'call home' to the controller. This involves integrating the necessary callhome plugin, configuring its startup, and ensuring its graceful shutdown within the RNC module's lifecycle.

Highlights

• Callhome Plugin Integration: The RNC Lighty Module now imports and utilizes NetconfCallhomePlugin and NetconfCallhomePluginBuilder classes, indicating the introduction of NETCONF callhome capabilities.
• Module Initialization and Configuration: A NetconfCallhomePlugin instance is initialized and started within the initModules() method of RncLightyModule. It is configured using existing lightyController services, NetconfConfiguration, RestConfConfiguration's host address, and a hardcoded port 4334.
• Error Handling and Resource Management: New exception handling for ExecutionException, InterruptedException, and TimeoutException has been added specifically for callhome plugin initialization. Additionally, the close() method now includes logic to properly shut down the NetconfCallhomePlugin instance, ensuring resource cleanup.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for NETCONF call-home functionality to the RNC application. The changes correctly initialize and shut down the call-home plugin. However, I've identified a few issues that should be addressed:

• Error handling for call-home initialization is incorrect; it reports success even on failure.
• The shutdown process for the call-home plugin doesn't check for success, which could hide resource cleanup issues.

I've provided detailed comments and suggestions to fix these issues.