Sync third party dependencies with latest odlparent #2388
Conversation
https://github.com/spring-projects/spring-boot/releases/tag/v3.4.0 JIRA: LIGHTY-349 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 1ad8026)
Spring Boot starting from version 3.4 has changed the way how client factory is selected. Now, we have auto-selected "jetty" for lighty.io. This selection is not fortunate because Spring is compatible with Jetty 12 but lighty.io is using Jetty 9. Thus bumping to Spring Boot 3.4 has introduced bean initialization error during tests. Manually select to use jdk's client to have the same behavior as before. See: Spring Boot uses Jetty 12 since 3.2 https://spring.io/blog/2023/11/23/spring-boot-3-2-0-available-now Info about client selection change in Spring Boot 3.4 https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.4-Release-Notes https://spring.io/blog/2024/11/24/bootiful-34-boot JIRA: LIGHTY-349 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 2df78b0)
https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.6.7 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
https://checkstyle.org/releasenotes.html#Release_11.0.1 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing third-party dependencies to newer versions, aligning the project with more recent releases of key frameworks and build tools. The primary goal is to enhance stability, leverage updated features, and maintain compatibility by upgrading Spring Boot components and updating code quality plugins. Additionally, a specific Spring HTTP client factory is now explicitly configured in an example application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several third-party dependencies, including Spring Boot, checkstyle, and SpotBugs, to align with the latest odlparent version. The changes are mostly version bumps in pom.xml files. Additionally, a new property is added to application.properties in one of the examples, likely to ensure compatibility with the upgraded Spring Boot. My review includes a suggestion to improve the maintainability of this new property by adding a comment.
lighty-examples/lighty-controller-springboot-netconf/src/main/resources/application.properties
Show resolved
Hide resolved
No description provided.