Squiz/SwitchDeclaration: make implied semicolon via close tag auto-fixable

The `Squiz.ControlStructures.SwitchDeclaration` sniff does _not_ include a rule/error for the scope opener not being a `:` colon, though all the error messages have the presumption of the scope opener being a colon in the textual content.

The sniff does have tests with a semicolon scope opener and as there is no error related to the semicolon being a scope opener, I can only presume that it was previously decided to allow that in the Squiz standard.
Considering that this is a code style sniff, it is not for this sniff to enforce PHP cross-version compatibility of code, so the PHP 8.5 deprecation is irrelevant and there is no reason to change the behaviour of the sniff for semicolon scope openers.

However, the sniff definitely did not function correctly for code moving in and out of PHP within a `switch` statement.
PR 1315 was a first step towards supporting this.

This commit now adds a new error to disallow a PHP close tag as the "scope_opener" for `case`/`default` statements.
The error is auto-fixable and will insert a colon before the PHP close tag as the fix.
With this additional error in place, the sniff's handling of code within a `switch` moving in and out of PHP has greatly improved.

Includes tests.

Author: jrfnl

src/Standards/Squiz/Sniffs/ControlStructures/SwitchDeclarationSniff.php

@@ -141,6 +141,19 @@ public function process(File $phpcsFile, int $stackPtr)
             }
 
             $opener = $tokens[$nextCase]['scope_opener'];
+
+            if ($tokens[$opener]['code'] === T_CLOSE_TAG) {
+                $error = 'There should be a colon before the PHP close tag to end the %s statement';
+                $code  = 'WrongOpener' . $type;
+                $data  = [strtoupper($type)];
+
+                $fix = $phpcsFile->addFixableError($error, $nextCase, $code, $data);
+                if ($fix === true) {
+                    $prevNonEmpty = $phpcsFile->findPrevious(T_WHITESPACE, ($opener - 1), null, true);
+                    $phpcsFile->fixer->addContent($prevNonEmpty, ':');
+                }
+            }
+
             if ($tokens[($opener - 1)]['type'] === 'T_WHITESPACE') {
                 $error = 'There must be no space before the colon in a ' . strtoupper($type) . ' statement';
                 $fix   = $phpcsFile->addFixableError($error, $nextCase, 'SpaceBeforeColon' . $type);

src/Standards/Squiz/Tests/ControlStructures/SwitchDeclarationUnitTest.inc

@@ -380,3 +380,19 @@ switch ($condition) {
     break;
 
 }
+
+// Verify that case/default statements with a PHP close tag as scope opener are handled correctly by the sniff.
+switch ($foo):
+    case "foo"?>
+        <div>Some html</div>
+        <?php break; ?>
+    <?php case "bar" ; ?>
+        <div>Some html</div>
+        <?php return; ?>
+    <?php default ?>
+        <div>Some html</div>
+    <?php goto FOO;
+    default ; ?>
+        <div>Some html</div>
+            <?php throw new Exception;
+endswitch;

src/Standards/Squiz/Tests/ControlStructures/SwitchDeclarationUnitTest.inc.fixed

@@ -404,3 +404,33 @@ switch ($condition) {
     break;
 
 }
+
+// Verify that case/default statements with a PHP close tag as scope opener are handled correctly by the sniff.
+switch ($foo):
+    case "foo":
+        ?>
+        <div>Some html</div>
+        <?php
+    break;
+
+    ?>
+    <?php
+    case "bar";
+        ?>
+        <div>Some html</div>
+        <?php
+    return;
+
+    ?>
+    <?php
+    default:
+        ?>
+        <div>Some html</div>
+    <?php
+    goto FOO;
+    default;
+        ?>
+        <div>Some html</div>
+            <?php
+    throw new Exception;
+endswitch;

src/Standards/Squiz/Tests/ControlStructures/SwitchDeclarationUnitTest.php

@@ -88,6 +88,14 @@ public function getErrorList()
             375 => 2,
             377 => 1,
             380 => 1,
+            386 => 1,
+            388 => 2,
+            389 => 3,
+            391 => 2,
+            392 => 3,
+            394 => 1,
+            395 => 2,
+            397 => 1,
         ];
     }