Return an ExcelException object rather than a string to represent MS Excel formula errors#1605

Draft

MarkBaker wants to merge 39 commits intomasterfrom

Excel-Formula-Exception-Codes

Commits on Aug 4, 2020

Return an ExcelException object rather than a string to represent MS Excel formula errors, so that formulae that return string values that do begin with a '#' can be distinguished from actual formu…
MarkBaker
committed
phpcs fixes
MarkBaker
committed
phpcs fixes
MarkBaker
committed
And the moral of the story: fixing one phpcs issue can actually create another
MarkBaker
committed
This should fix all the scrutinizer issues with the actual code, leaving only its problems with the unit tests... pity it doesn't recognise the validity of previous assertions in a test
MarkBaker
committed
Simplify some of our nested ifs
MarkBaker
committed
Refactor of xls writer for formulae
MarkBaker
committed
Fix phpcs issue
MarkBaker
committed
Fix phpcs issue
MarkBaker
committed
Fix exception return datatypes in Engineering functions
MarkBaker
committed
Fix exception return datatypes in Engineering and Statistical functions
MarkBaker
committed
Fix some more phpcs issues
MarkBaker
committed

Commits on Aug 5, 2020

Minor refactoring of HTML Cell writer to eliminate pass by reference
MarkBaker
committed
Eliminate some redundant code
MarkBaker
committed
Try to let scrutinizer now that we have identified object types in tests
MarkBaker
committed
Ok, let's try and keep phpcs happy with our attempted hackaround for Scrutinizer
MarkBaker
committed
Seriously?!? `/**` is acceptable outside a method, but inside the method only `/*` is allowed?!?
MarkBaker
committed
So let's see in Scrutinizer prefers this approach
MarkBaker
committed
So let's see in Scrutinizer prefers this approach
MarkBaker
committed
For the sake of a space
MarkBaker
committed
Scrutinizer really is pretty f***ing stupid
MarkBaker
committed
Fix some return typehinting for Date and Financial functions
MarkBaker
committed
Fix some return typehinting for Financial functions
MarkBaker
committed
Fix some return type docblocks for DateTime and Financial functions
MarkBaker
committed

Commits on Aug 6, 2020

Excel error returns in unit tests are now ExcelException rather than string
MarkBaker
committed

Commits on Aug 7, 2020

Commits on Aug 10, 2020

Extra typehinting
MarkBaker
committed
Extra typehinting
MarkBaker
committed

Commits on Aug 11, 2020

Commits on Aug 12, 2020

Extra typehinting
MarkBaker
committed

Commits on Aug 26, 2020

Extra typehinting
MarkBaker
committed

Commits on Jan 29, 2021

Update NamedFormula.php (#1701)
rachvela94
authored