[Backport] 5.0 backports#2078

Merged

furszy merged 86 commits intoPIVX-Project:5.0from

Fuzzbawls:5.0-backports

Dec 21, 2020

Commits on Dec 16, 2020

Commits on Dec 17, 2020

[BUG][RPC] Fix check in wallet upgrade RPC

random-zebra
authored and
Fuzzbawls
committed
[RPC] Add nullifiers to listshieldedunspent output

random-zebra
authored and
Fuzzbawls
committed
[Tests] Check spent nullifier in sapling_wallet_listreceived

random-zebra
authored and
Fuzzbawls
committed
[Wallet] BugFix: automatic upgrade for unlocked wallet isn't upgrading the wallet feature version.

furszy
authored and
Fuzzbawls
committed
Make tests pass after 2020

bmwiedemann
authored and
Fuzzbawls
committed
[GUI] Transaction detail, scroll memo fix, starting from the top.

furszy
authored and
Fuzzbawls
committed
Make failures to connect via Socks5() more informative and less unnecessarily scary.

furszy
authored and
Fuzzbawls
committed
SOCKS5 connecting and connected messages with -debug=net.

furszy
authored and
Fuzzbawls
committed
Make Socks5() InterruptibleRecv() timeout/failures informative.

furszy
authored and
Fuzzbawls
committed
Use Socks5ErrorString() to decode error responses from socks proxy.

furszy
authored and
Fuzzbawls
committed
Revert "Use async name resolving to improve net thread responsiveness"

furszy
authored and
Fuzzbawls
committed
[net] Avoid initialization to a value that is never read

furszy
authored and
Fuzzbawls
committed
[Masternode] Cache decoded Masternode private key

furszy
authored and
Fuzzbawls
committed
[Masternode] Stop parsing the masternode private key string on every ping.

furszy
authored and
Fuzzbawls
committed
[Masternode] Stop parsing the MN private key string on every finalized budget vote.

furszy
authored and
Fuzzbawls
committed
[Masternode] Clean now unused global strMasterNodePrivKey.

furszy
authored and
Fuzzbawls
committed
[Masternde] Refactor activeMasternode.GetKeys callers to not expect a bool.

furszy
authored and
Fuzzbawls
committed
[Validation] Remove unused ReprocessBlocks function.

furszy
authored and
Fuzzbawls
committed
[Validation] Remove unused DisconnectBlocks function.

furszy
authored and
Fuzzbawls
committed
[Validation] Remove unused DisconnectBlock function definition.

furszy
authored and
Fuzzbawls
committed
MN: pass lastPing to CMasternodeBroadcast constructor

random-zebra
authored and
Fuzzbawls
committed
MN: pass sigTime to CMasternodePing constructor

random-zebra
authored and
Fuzzbawls
committed
Refactor: always check mnp blockhash in CMasternodePing::CheckAndUpdate

random-zebra
authored and
Fuzzbawls
committed
[RPC] Redirect sendtoaddress to shieldedsendmany when shielded recipient

random-zebra
authored and
Fuzzbawls
committed
[Test] Add case for (shielded) sendtoaddress

random-zebra
authored and
Fuzzbawls
committed
Refactor: Decouple ShieldedSendManyTo from sendtoaddress/sendmany

random-zebra
authored and
Fuzzbawls
committed
Trivial: Add Zcash copyright

random-zebra
authored and
Fuzzbawls
committed

Commits on Dec 19, 2020

Miner: do not include more than 750 kB of shielded txes inside a block

random-zebra
authored and
Fuzzbawls
committed
Consensus: check total size of all shielded txes inside a block

random-zebra
authored and
Fuzzbawls
committed
Tests: Add sapling_fillblock functional test

random-zebra
authored and
Fuzzbawls
committed
[GUI][Trivial] Adjust CoinControl column widths for readability

ambassador000
authored and
Fuzzbawls
committed
BUG: SSPKM, guard GetDebit/GetCredit for non-shield v2 txes

random-zebra
authored and
Fuzzbawls
committed
BUG: Guard access to tx.sapData in connectBlock

random-zebra
authored and
Fuzzbawls
committed
Tests: fix order of sapData serialization

random-zebra
authored and
Fuzzbawls
committed
Tests: Add trolling exploit demo

random-zebra
authored and
Fuzzbawls
committed
Script: Properly sign/verify shielded tx with sigversion sapling

random-zebra
authored and
Fuzzbawls
committed
Tests: update sighash json test data for saplingVersion txes

random-zebra
authored and
Fuzzbawls
committed
Tests: Update sapling_malleable-sigs test, now failing

random-zebra
authored and
Fuzzbawls
committed
[Cleanup] Remove unused global fields from util.h/cpp

furszy
authored and
Fuzzbawls
committed
Separate CTranslationInterface from CClientUIInterface

furszy
authored and
Fuzzbawls
committed
Make QT runawayException call GetWarnings instead of directly access strMiscWarning.

furszy
authored and
Fuzzbawls
committed
Eliminate data races for strMiscWarning and fLargeWork*Found.

furszy
authored and
Fuzzbawls
committed
util GetWarnings, adding "gui" parameter type.

furszy
authored and
Fuzzbawls
committed
Move GetWarnings() into its own file.

furszy
authored and
Fuzzbawls
committed
[GUI] Connect alert signal

furszy
authored and
Fuzzbawls
committed
BUG: Fix TestBlockValidity for PoW blocks

random-zebra
authored and
Fuzzbawls
committed
Consensus: reject blocks with outdated version (<8) after v5 enforcement

random-zebra
authored and
Fuzzbawls
committed
Miner: set proper block version based on upgrade enforcements

random-zebra
authored and
Fuzzbawls
committed
Cleanup: remove unneeded check (time-based) for version 4 header

random-zebra
authored and
Fuzzbawls
committed
[Consensus] Bump TxVersion::SAPLING to 3

random-zebra
authored and
Fuzzbawls
committed
[Wallet] Do not perform ECDSA signing in the fee calculation inner loop

random-zebra
authored and
Fuzzbawls
committed
Sapling: Decouple ProveAndSign from Build

random-zebra
authored and
Fuzzbawls
committed
Sapling: add option to skip ProveAndSing in TransactionBuilder::Build

random-zebra
authored and
Fuzzbawls
committed
Sapling: Skip proofs and signatures during fee calculation loop

random-zebra
authored and
Fuzzbawls
committed
Refactor: initialize dummy Spend/Output descriptions only once

random-zebra
authored and
Fuzzbawls
committed
[BUG][GUI] Receive widget: check typeRole before refreshing view

random-zebra
authored and
Fuzzbawls
committed
Consensus: Budget: Fix instant killing of proposals

random-zebra
authored and
Fuzzbawls
committed
BUG: Miner don't check for PoS activation at negative height

random-zebra
authored and
Fuzzbawls
committed
Params: change testnet datadir to testnet5

random-zebra
authored and
Fuzzbawls
committed
Params: Update testnet params - remove unused ones

random-zebra
authored and
Fuzzbawls
committed
Params: Fix PoS block value for testnet to 5

random-zebra
authored and
Fuzzbawls
committed
Params: clear testnet checkpoints

random-zebra
authored and
Fuzzbawls
committed
GUI: Dashboard, fix type filtering disappearance.

furszy
authored and
Fuzzbawls
committed
Consensus: update spork keys for v5

random-zebra
authored and
Fuzzbawls
committed
Consensus: Allow setting old spork key before its expiration

random-zebra
authored and
Fuzzbawls
committed

Commits on Dec 21, 2020

Wallet: return unconfirmed balance for all spendable coins by default

random-zebra
authored and
Fuzzbawls
committed
Tests: minor fixes for mining_pos_reorg_py

random-zebra
authored and
Fuzzbawls
committed
[BUG] Miner not paying valid finalized budget if <20 active masternodes

random-zebra
authored and
Fuzzbawls
committed
[Build] Unify header file extensions
Fuzzbawls
committed
Fix typo in `getsaplingnotescount` help text
Fuzzbawls
committed
Don't bother registering the `multisend` command
Fuzzbawls
committed
Fixup various formatting inconsistencies with RPC help output
Fuzzbawls
committed
Add new prevector benchmarks.

random-zebra
authored and
Fuzzbawls
committed
Reduce redundant code of prevector and speed it up

random-zebra
authored and
Fuzzbawls
committed
Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h

Empact
authored and
Fuzzbawls
committed
warnings: Compiler warning on memset usage for non-trivial type

ldm5180
authored and
Fuzzbawls
committed
GUI: ccontrol: remove column checkbox extra whitespace in tree mode

random-zebra
authored and
Fuzzbawls
committed
GUI: settings information, fix missing initial masternodes count value.

furszy
authored and
Fuzzbawls
committed
[RPC] Use "shield" nomenclature instead of "shielded"
Fuzzbawls
committed
Only use one set of parentheses for optional arguments
Fuzzbawls
committed
[Refactor] Pass caught logic_error by reference in CreateSig

random-zebra
authored and
Fuzzbawls
committed