Fix bug of graph_net/torch/fx_graph_cache_util.py and valiate samples of dtype generlization pass #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
lixinqi
reviewed
Jan 4, 2026
| from torch.fx.passes.shape_prop import ShapeProp | ||
|
|
||
|
|
||
| def parse_immutable_model_path_into_sole_graph_module(model_path, device=None): |
Collaborator
There was a problem hiding this comment.
这个基础函数不可以改。它的名字没有shape propagate的语义。
lixinqi
reviewed
Jan 4, 2026
Collaborator
There was a problem hiding this comment.
这些测试代码太复杂了，没法review。应该写成标准的sample_pass的test。可以借鉴#514 这个pr的graph_net/test/subgraph_input_shapes_naive_rewriter_test.sh的写法。
Contributor
Author
|
lixinqi
reviewed
Jan 7, 2026
graph_net/test/dtype_gen_test.sh
Outdated
Comment on lines
53
to
55
| for sample in "$TORCHVISION_ROOT"/*; do | ||
| python3 -m graph_net.model_path_handler --model-path $sample --handler-config=$CONFIG_APPLY | ||
| done |
Collaborator
There was a problem hiding this comment.
这里直接指定了torchvision，这是不对的。应该取自graph_net/config/small100_torch_samples_list.txt。
graph_net/test/dtype_gen_test.sh
Outdated
| else | ||
| echo "FAIL" | ||
| fi | ||
| done |
Collaborator
There was a problem hiding this comment.
替换为
done | tee >(grep SUCCESS | wc -l | xargs -I{} echo SUCCESS {}) | tee >(grep FAIL | wc -l | xargs -I{} echo FAIL {}); wait这样表示统计最终的成功与失败的个数
WHoutstanding
commented
Jan 7, 2026
Contributor
Author
There was a problem hiding this comment.
parse_immutable_model_path_into_sole_graph_module()返回的trace_model不包含tensor_meta导致dtype_pass.need_rewrite(traced_model)返回总是false，所以改为调用get_torch_module_and_inputs和parse_sole_graph_module和ShapeProp(traced_model).propagate(*inputs)，使trace_model包含tensor_meta
Contributor
Author
测试了small100_torch_samples_list.txt， dtype generlization pass 成功了 74个（float16 bfloat6），成功率74%
|
lixinqi
approved these changes
Jan 8, 2026
| @@ -1,12 +1,12 @@ | |||
| #!/bin/bash | |||
| # !/bin/bash | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Description