Skip to content

Conversation

@c4phesua
Copy link
Contributor

@c4phesua c4phesua commented Feb 18, 2025

Description

The check for maximum and minimum values missed the zero value, which is a falsy, so it was not rendered.

Motivation and Context

I’m using this addon for my project, but it doesn’t render the minimum/maximum value. #754 was supposed to fix the issue, but it still persists, so I decided to resolve it myself.

How Has This Been Tested?

  • Added more unit tests to cover all new cases and ensure both new and existing tests pass.
  • Tested in the demo, and everything is working fine.

Screenshots

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 29b609a):

https://docusaurus-openapi-36b86--pr1087-sp1tyjgb.web.app

(expires Thu, 20 Mar 2025 22:39:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@sserrata
Copy link
Member

Hi @c4phesua, good catch! The changes LGTM...I'll work to merge by EOD. Thanks!

@sserrata sserrata merged commit 15fd9ba into PaloAltoNetworks:main Feb 19, 2025
13 checks passed
@c4phesua
Copy link
Contributor Author

Thank you @sserrata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants