Skip to content

Conversation

@ahelmy
Copy link
Contributor

@ahelmy ahelmy commented Oct 14, 2024

Description

Fix allOf in the API response for objects.

Motivation and Context

Fixing #806

How Has This Been Tested?

  • Modified demo to local specs.
  • Tested and revert back to same demo specs.

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@ahelmy
Copy link
Contributor Author

ahelmy commented Oct 14, 2024

@sserrata For your review please :)

@sserrata
Copy link
Member

Hi @ahelmy, thanks for the PR. In #979 I'm experimenting with a different library for resolving/merging allOf schemas. I'll make sure the scenario you addressed here is also covered.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 6557a3d):

https://docusaurus-openapi-36b86--pr995-hlrmde1e.web.app

(expires Fri, 15 Nov 2024 13:19:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@ahelmy
Copy link
Contributor Author

ahelmy commented Oct 16, 2024

thank you @sserrata 👍

@sserrata sserrata merged commit 3d1cc0d into PaloAltoNetworks:main Oct 16, 2024
13 checks passed
@sserrata
Copy link
Member

Here's a preview: https://docusaurus-openapi-36b86--pr979-fgr4lcvg.web.app/tests/all-of-with-array-items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants