Sweepers require level during instantiation #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlunet
reviewed
Jul 23, 2025
tlunet
reviewed
Jul 23, 2025
tlunet
reviewed
Jul 23, 2025
|
So, are we going to keep it, merge it, or throw it away? |
|
It's fine enough for now, let's merge it |
brownbaerchen
added a commit
to brownbaerchen/pySDC
that referenced
this pull request
Aug 5, 2025
pancetta
pushed a commit
that referenced
this pull request
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @danielru has correctly noted 10 years ago in #46, the sweepers can be instantiated, but not used without a level.
Since I now have some capacity for tending the garden, I thought I'd change that.
I also think it makes it easier get started with developing a new sweeper since its now more obvious that sweeper and level interact.
Note that it is possible to pass
Noneas the level in the SDC sweepers. The sweepers have setters for the level that make sure you pass a proper level, but they are not used during instantiation. In some tests, sweepers are instantiated to check the attached collocation problem, so we should keep this.Closes #46