Remove left panel EHP, saner Vaal/Guard skill defaults, better disabled gem readability #8340
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, better disabled gem readability
Contributor
|
I agree with the idea of disabling vaal/guard skills by default, so +1 to that. But I don't quite like moving longstanding UI elements to different pages, intentional obfuscation of a commonly observed stat might not be the best UX choice. edit: is there a better way to educate users about this stat's true meaning? |
Contributor
Author
Well, to be honest, the primary intention here is to remove it from prominence as it's more often harmful than helpful. This approach was proposed as a consensus from a plurality of the largest build creators. This more of a biased change proposal than QoL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EHP being so prominent in the left panel has been the source of much misinterpretation of the sturdiness of builds in PoE. While it can be a useful number to veterans, it is deceptive to folks that don't know exactly how it works. With the support of many prominent build makers, I'm hoping to remove it from the left panel display here. The number is much more useful with more clarity when taken with the context of the Calcs page.
This is configurable in the options panel for those who want to turn it back on.
Over the past couple years certain standards have arisen within the build community for what is a sane state to consider and share builds from. Chief among these is Vaal and Guard skills (both Vaal and non-Vaal) being disabled. I've made it so that this is the default upon character import. The non-Vaal version of that skill will now be enabled. This is very useful when reimporting a character multiple times so you are generally looking at the state you want the build to be configured in by default.
In addition, I've added a (Disabled) tag for the auto-generated skill labels so it's more clear what is turned on/off in a socket group at a glance.
An image of skills in a fresh import:
