Skip to content

Conversation

@Peechey
Copy link
Contributor

@Peechey Peechey commented Nov 22, 2025

Fixes #8031

Description of the problem being solved:

Fixes Wings of Entropy and its Replica disabling dual wield and one handed axe skills like Swordstorm, Lacerate of Haemorrhage, and Chain Hook. This also fixes Wings allowing Lacerate of Butchering, which requires a Two Handed Axe or Sword. The dual wielding mod for Wings overwrites the Two Handed Axe match for Butchering, tested in game. Ice Crash of Cadence does work with Wings in game and has some odd weaponTypes so a little extra code was needed to differentiate for Butchering vs Cadence.

Tested against a number of skills, including skills that should not have been affected and a few other weapon combinations like Dual Strike of Ambidexterity. The logic changed for weaponFlags is exclusive to "Counts as Dual Wielding" items so any other skill/weapon combination should be unchanged.

Link to a build that showcases this PR:

eNrtXW1z2ziS_hz_Cpaq9mqmEsl81UvO2S35LfauHXslZzz7aQomIYsbitSQoB3Plv_7dQMkRVIUCVrcurm9SapmJLD7AbrR6G40ROToL99XnvJEw8gN_E89baD2FOrbgeP6j596X-_O--PeX_58cHRL2PJmcRy7Hj7588G7I_5ZWRHXnwf2N8o-h0G8BoSe8kB8x2Wfel8Cn_aUJ5c-XwcO_dS7vL69md31FNsjUfSFrKBpbkO3PYWR8JGyn9JRGL_AKEhkU9852dAKuDXx2ZIG_jX5ZxB-DpytdtcvtNtLEhKb0fCKPlFvGrNADIaFMTz1sBEHDRK9O7r1yAsN54ww5Yl4MVAZ44Gm6pPhxByOR1ZPieDZp94U9EUe6SlZwX97hzt4TX0wVsemZmnbrMdxGLEGfm2gjccp33xNqbOT1BqMUsLbkJ4tFtRm7hM9CV12siS-vbsTdaCPs8FJ0GuDAvV17DF37bk03D22lP6iEdy0BvpwaOijkT7O6ewuYMQ7vZ3vFqJIGbCdlBN9MLI0E7rQhnrWwbEHyq3rQAM7ULXRaKiapqUZKd-9y5aNvOrAhN5MUx0aWYeXj77LaB0XqGI4McyRNproxkYV2KMUc5Uekfk2cKPAr2OeGANtNLZGw9FoUp6DgElNw0nseeAlpGhnNKLhE2Fu_ahwBkzTnKimpY6H2QycBKsH16-fAGOQraJpSMnNQqyPGXHcOLqmLKRRTbcp6zXxyUkQsWaJkPKWhuC9WC2DZqFEJa45tQPwem07asl55S6oPKWMMGWGtqN5mxxnc1m61sBvG9AMHLoc5TyIvVpKfUPKwhojsjYr6dc6yg3eKf0uiVdHucG79JkkXh1lbnhPAbqD3e5tNNBHk7FlGoZmGXrBRZ1d3O7kG2Zd3C5fItcm3jX57q7iFUSmO_KN7u7RGG1s9XHJfHBu7VnP3ZC25zoJPEeaK3N0EGiDSJbNzHkU17-A7G1q2zFkTS8SLDeLhRTHsLDcJdbHmtofkfTStyVBv_ohDyY1iVKRYQYrG_OxB68m4VF39JE4CDn3NqOP1E-6e5FjuaLUXn6GCZkRtnt4ViEaSKoVSevUWgSVUGtOSUWORiUNJnnGlmpCFjk1bRy7T8PHl_nSpZ7Tjjod1glZS6o5z12n7h3dtVJFnrWlSu5J6MhFNjkquZFrw2zoTySqc_clpQpqKX1eU0jOgcGhTbugze4p-Cfunbx2bNNwFcShpASCWEqANE6JneKMOrFdGxmNjT2ke8BjD3bnDXJMtrhgoJ4nw7pRAWPE_nYaOI_SWuOdtOIojm8er9fgaNAcGgD6G7-PURj2HK5MjrahvQFbrlv4uQ4wYMt2sKFt0UGWgsj2UmJoIwumEdLCbIibutC2JvQavMUKIgWvc1wHEg7pHDaZUjtMTii5c70NnmHkSyxH7d4UGlXUkGxJDCWk_m8v0vgFcqkOznwH0jBYCtJ9lDk23dy5K_CfUXRKGFGcJCn_iYQu8ZnG57DUqIuJpSS0l1dgBZ96-W_nxPMewEXwVl4xPHc9RsNTeIb9oxTY8dEhryzip7uQUoWkC97O6nT4JV8fvHSECvhGjYQv0-Ij3_V6Cmzzaa7AqEOCvSIR9P8ibDDCcfmBQ-GDNR4bRlKnFNjY7bujr7Mr_uHdkrF19PHw8Pn5ebAmbBks6HeIGQM7WB2ugQkG3I--uZ7Xx24Pp_Dn-HHK_3CgwxTpSNROo0PxDddN6MIYxAwcoqBcJagJ_HAS-Av3MdGJ-DKnLFNM1qK4Dp8M5jKP4pZqQWKPJWKANdh0Ca6Hhoofrx5oyGl9UZFdwojm6MsT46mmH6kpA_Xp6iUJUIHnzYifJgrVnFaRs9KbVXMaRU6sP-ZLqDuYqnu7TfdD1Vy6bmoFRgwFzZ2VZCvHmh2qVzWzOMpCRrSjp5TBFlMOhsJC4t25j-CRgthn8jrBINSgDmNLrAYGLRsf-hCarvFalpQjch9d72bBnSsYYubFJGcKxWmeqZFanKpcfV1qastRvmlV2QG4weZlVTbxcvyt5hpqk_GkwJhPSCX1li0NCTPfWof5_KuaZzwZbovW3FXOkLKjBqxj05A6XJ3c2OfUW7QStphY147bLGoJD4zq6M1sBtfZXqJo_keHmZvmvl18w49zDBkRhFXurT_T1ZU4nvKDcJUVqyDOLYPnqcf-HhPPZS9ABiFrQbyIYmANkS86foF05xw3g8UaOefFvFnQ3b2sMd5Nr656uV4TYBFT84DpqVkSknG0-eiTNiTBJwlw2KhQH4ssTgqAp4bTDQhfKK5ve7FDL_0ksctk8sgDKmGL64R4dpR19O4IhqnYaA0c7lchBIbvNPpB7sPzFGy7gpkLYXsMevxHRiwkRuxtkuSkUE-mV-QjKYkSLJQLQldBGC7RnhJ5P3vBA_G0VGqOfEtClo28QKendI90hf1fU0YcyL0OLxlMwCHOwiEXHA0j6bhX1mzWB8If7qmZn5s187OEZo5jZsOCBdeyQzG_Qy3Mn4PQiRgsvB06yBNUaiBP0KnUM2p_C_ycNlOx3yQo-GHXvwiCbzvkzD2vFJM_VwRBp2LmOu5SzJoFX6JpEBct-y4EG1vG0e9a9HnsQ4DaZcbJw2oTTh52KlwRtMMlewqP5yx0v9W5rjJRpdxIpAgqnOUpxE-Hfoe9IsB1rI3NeLqZ62dK1zs9Fn-2w1nxZ91OdB5zL6nOcJVFS8LYTjsuklTKWCTpVNQq6A4t-9KmJyGJljV2XSSplB9IFE6DNn1CHIoZabd6SEdRPetHgu53nRf-DTJl5trHHoEtV7WqiySVqk5IlISmUx0Xu-8-8RGbgzmxYYd170braGfk2Cas9i2cQklIutFFtoMpdN-sjP8LJjgDrJvFNAyD5126L5JUah1JePBKiLpNQQv9d5Kj8Am9dvHHkdMQtwv1ZlekrNSAIFFSmo4NrziABneXfEx3_GKfjx8vVwin0O_4PzTVl9S2eCmc95xst_FzstsWu3hG2Km7WNAQHXmUDj6OqPjB0j0l68DnHAKRDwRR0uJwov9PvaGw0xnBBOej8vXL5d-_nh3cwxYjQhM681kYrF8Ozn4LVi-wpZt-pwdJyf-jchtSRRsYA7XYpA_UcpMxMLebNG27TR_m207iECRkB3PqUZuBI8meDA_-lYjw0XrNDy5r1j7oH4wP5qvIOUEe_jipb3xUdPUgqb9_VGb97O8BL7vM6K_QhX4AU-S5tos0agn5dfQnRVS-FBYo_LhU4SeTiqgrbcjN13-FWBj_qA6s1x-G_dGPspzWh2GBd9TXVGlm7fW9pm4Ti7PahFp5XroeVXjOe48VI1DTBkHo7_14L5CSDO9_GPc1_ce9IEH_BbWMVYBExYCvDimJwE7SGt-WVlCiPK-mtmAuz8dQ7Y8lWVNrzLFPHSdSfrCs_tD6EfWQjUXBInuqCfDk13zbSXwnb_NbQCMLrENNkIZWX1elkIbbSJqlCm6EMgy1b8pBtZKR14BzeDeLxRtlbEaqlFHra5NJKqMGMmo1ULzSDN44KtkkuvrrwOEHX6lr5V3hz5usNBgUKPRGCqORwmyksBopho0Uo0aKcSPFpJFCU5tJmrWqNatVa9ar1qxYrVmzWoVqj3gmUQzDei4M65VheEYx_hClNhxfUfIY04_KBXUj9tZ4qu8VGdvGqG7iQStPvGsF5-JleVgICONJnYCCh10cMikPiSHn4mURQUMv2hKiMIgfwA-PEGEVwFxmDlchQjURHlvu6B1Z0VPW8_7hvWSWqSGxTJ0HSr4dzOIIFxWv_pdT4v3W4ec-_M0vOj1vM9o4b_liR6Okv8pWZoQV07pXU5WgB_PJU2ULkcLW0leugmcFf6l8YKl1q44HWx2XwHDrmVbgTNb7XBh1fh3pat8QMX8lTkFFx5-BhiE4flPWNATnSFcvyoXL_jBsKcM2c4ZtVBr2eRhE7AFmiC0PbkIfz_SuiU1rbVvEHVXO3I2asJMLOJa60_aLtjxnsQ8OPuTvlKGdok24NCpsal41609KiD-oBQ5hNJzvbhnSCI_0d241ktxx2Nd1kTnqw74BH3dvN7a5Exaedw77Zh23ZO_4e5S39VzgzO-o-pr5o9zqNNW-lUQ5vkMQv1gRUS2HaFiCbAN5ssQKXNVcic4i5dllS4Ut3UgR9QzFoaAkJ4gfvGwnAt1yoGQmkf2Pxf9vycmrPIhV6TVufKrg73SULwHMHoSS-YrAVJ94GB5D5a_0mXpZ1npKPTd041Uxo-QGexF4HoSZW-KtlDtqL33315hKTW_VWIeNYfzKXT1EMAh2cB8EDv8E462vWnWUUWtGUf73Glo2f45pv-Dm_g16ewTVYkUyH9LvQvfxEZQrWDTlM6Z9_Pecz-SJ4uriL0RgdFTchfISxMoSHxCmeLAemQKb_gy9uMI1K42_Vc959UWtz735bFqIoKnbibl4YTjJiP_DVm-VIY4awy7YUOzDpIQEPoKmjj3ibPZ5txR6ceJIIgrr-4VhkXXm9n1mVykoBOH35lBFk9hJVC7zQaQZylb5Xlta6FasxKpXUrJK2Ot48IUriK9940cF30srZqMijiVBLbcPRZ-IrhL3ZTAksT6TSMd_nPf_LpJVrZZx41nFdE3X_wVai_47UvAdtIObFexR7rFsV1ohxvYKGckdS2iTisWltT6qGL5uxlYum36wXm_WWJnAh5XL8bgPf_NZcSFoGLuqCNqoXypwVx8YpKMopG1jzBObeYt1cX3UNzQJrsr81lKzYvEEV55VKstiHEK0qFDU_1CqzQssBDDSejH4D22i7kbLC8BDXiFbxRhZkf5aWZlIwObT3-J5UXGjwt0E3gHAwzs_EyweUojLOiIeqV1_AbPMRP6bDFwHuAV_iWXn-UQTBDo5npSXcYQ2r4KIKqYqhsr3_QgUQyMRI_4j0_5fq35XecpJY4I7d70nGj7gK1_Lg5MwdqhyHDzXHt6-rVLVL2cOulx6C6MpZbZbBVHZAze9bQpQU456b1RmKjzqa2o55P-Nb0f_sxPZ3Gtm9T86eHc09wKWvBWRJDeaMn14iSKsgvOJV6A_F0BvH77OrvAXNfhFvHt3uAtDV-bPZF0G0roC0rsCMt8C9G_AsDrAaDNNF9RbAcse81ONoO-NYOyNYO6NYO2N0GYujgPnRRFvhe0zITUwejcwRjcwZjcwbSbpmHr7TVEFf7u5CWBTuQcA7NifaNT5EKx9AdqYxLlHom-txiw49H0H2XamW4-wjUV_Dsmi5YqsMD59b9sx9hyBsfcI3pBWaJVB3Gqt_v2XntnV4Pd1Q-beouxri9ZbVNG5L-xiFG9OKzvo2-jKoLQOBmN2gGF1JdDe_t9s7dA7mwyjg7ze2Ff-Ngqc4VlP-yy-K311sZfS2orbUV47bNtv6_SttZN8m2AdzMFbPGkLlukq9t5idPre-UNqvTtYtLZ9D1v7Jqsrsd_s5Or5RClKvE-D90QRh875TVP3FK8xicRFUvz1GX5tEr6PJQpX_jpmSsRCfr_92fn52cnd5U9n2SUjbmT_8hAvFnhJfNKVYNm-pgbL37-I5oRyTvn1fLwqlrzwgxXTnhLFD5F49qn3k0uf-cNTyojrwfKxA88j6whfH9q8-1NEu8iuOipgcZzcMwmke9BS6OKqzQOdfach1jM3TyWg8KL17eGIseDlj3iBmBSQuHynACVqr3jiwi-xlEHB39UWQbBFTpTL1Zp4JeWmbTICoOB4XosvZUUVSmF4lrumtrtw7YRGbtaTi3WKuknv2pXB4PfTF_mTJglmcXpU5E7bZLTKb6ovaTVpk7EvapOXInfSJMGcXYJaBMiaA_8CzUUC6cyjU9fDywlLM_sl8Lmxw7rZEEgAXoOTSS6dKwLe4L1G2RMJJFglofsQs_JyzrfL6ApvZC6qibfIyIK3DhdYRYuMXvNX8Ra9UeGJnFMrQYgWCdbkdq0Cs2iTnIIkmymoP2mTUUJy1VtR_rRRZpFwdzt9Clxn21NsPdwXkL-X0cG48NLX_WHKt8BKIfIEp7Re0rY3sn9lLh6CVqBsXgduBMEltx8Crrz9EO5c32ZxSKUAZlvpyKychOzgTC8nLQbrtPGN_NlFpm9GENetvpmdX1gow43-_5Qu-GvbFQFg80gyllRjnQeQ0UG6wX9avScW_jQ-_ZX2nlBcxGqP9DZ1JaG3Ums7EIVTEf8oQoW_TB5Ie6ddQJAXXMgmoDuRshuSLyjx8N_vCbz9AMv_KsReYHjNe7wmvpPC3VTl_a2nIWARYPJ7gE_xNvl9dcivqN0GysZ1dJjuEI--BJA1ITS2pl_4TcS4cVN-C4L0VkbY2uK3n_n9FPjpH-Kmit13M4jLkOcMtpGiW37jg-LQCPZeJMkdPJjfOd7w6DzhCrmDCd_c70jWa-rnVXB0WP6X2f4H-WaouQ==

Before screenshot:

image image image

After screenshot:

image image image

@Peechey Peechey added the enhancement New feature, calculation, or mod label Nov 22, 2025
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently breaks tests

…mo, Swordstorm

Fix Wings working with Laacerate of Butchery when it shouldn't, keep Ice Crash of Cadence working even with its weird 2H weaponTypes
@Peechey Peechey force-pushed the fix/wings-of-entropy-skill-interactions branch from 5b56dd9 to 8217546 Compare November 23, 2025 02:10
@Peechey Peechey added bug: behaviour Behavioral differences and removed enhancement New feature, calculation, or mod labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

swordstorm/wings of entropy

2 participants