-
Notifications
You must be signed in to change notification settings - Fork 136
[nexus] base64 decode SSH private key before use #3612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds base64 decoding functionality for SSH private keys in the postgres connection module. The change ensures that base64-encoded SSH private keys are properly decoded before being used for authentication.
Key changes:
- Added base64 dependency and decoding logic for SSH private key authentication
- Improved error handling for private key decoding failures
- Minor code formatting improvement for SQL parameter types array
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
nexus/postgres-connection/src/lib.rs | Added base64 decoding of SSH private keys with proper error handling |
nexus/postgres-connection/Cargo.toml | Added base64 dependency version 0.22 |
nexus/catalog/src/lib.rs | Reformatted SQL parameter types array for better readability |
Comments suppressed due to low confidence (1)
nexus/postgres-connection/src/lib.rs:1
- The SQL query has 7 placeholders ($1 through $7) but the parameter types array only has 6 elements. This mismatch will cause a runtime error.
use base64::Engine;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
❌ 2 Tests Failed:
View the full list of 4 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Also fixing INSERT statement for
create_qrep_flow_job_entry
, it had more placeholders than columns post #3493