Skip to content

toke.c: S_intuit_more: More effectively use S_scan_ident #23880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: blead
Choose a base branch
from
+175 −105
Open

toke.c: S_intuit_more: More effectively use S_scan_ident #23880

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3b86b9c
toke.c: S_intuit_more: Simplify a bit of code
khwilliamson Aug 17, 2025
b302a19
intuit_more: Handle easy thing first
khwilliamson Sep 5, 2025
eb6d467
intuit_more: White space only
khwilliamson Sep 5, 2025
5eeec5e
intuit_more: Reserve first byte of buffer
khwilliamson Oct 27, 2025
2aeccb9
intuit_more: Move declaration to first use
khwilliamson Oct 27, 2025
5d79145
intuit_more: Look for more variable types.
khwilliamson Oct 27, 2025
26848f0
intuit_more: White-space only
khwilliamson Oct 27, 2025
7eb08b7
intuit_more: Remove over allocation of buffer
khwilliamson Oct 27, 2025
b61e5b8
intuit_more: Save scan_ident return
khwilliamson Oct 27, 2025
ac4d84e
intuit_more: 0 length identifier means nothing more
khwilliamson Oct 27, 2025
5e9f082
intuit_more: Handle numeric identifiers
khwilliamson Oct 27, 2025
9f31304
intuit_more: Check if identifier exists
khwilliamson Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions toke.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4811,8 +4811,11 @@ S_intuit_more(pTHX_ char *s, char *e,


case '\\':
if (s[1]) {
if (memCHRs("wds]", s[1])) {
if (s[1] == '\0') {
Copy link

@happy-barney happy-barney Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally: great change, maybe even add break into then branches and get rid of else if branches

Curious question: common pattern is condition if (s[1]), so why not use if (! s[1] as well

/* \ followed by NUL strongly indicates character class */
weight += 100;
}
else if (memCHRs("wds]", s[1])) {
weight += 100; /* \w \d \s => strongly charclass */
/* khw: \] can't happen, as any ']' is beyond our search.
* Why not \W \D \S \h \v, etc as well? Should they have
Expand Down Expand Up @@ -4866,9 +4869,6 @@ S_intuit_more(pTHX_ char *s, char *e,
* purposes of the 'seen' array. Whatever is matched by these
* backslashed sequences should not be added to 'seen'. That
* includes the backslash. */
}
else /* \ followed by NUL strongly indicates character class */
weight += 100;
break;

case '-':
Expand Down