Collect names of multiple erroring parameters #23888
Open
+70
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
force-pushed
the
named-parameters-collect-errors
branch
from
9eeb8b1 to
2414522
Compare
wolfsage
requested changes
Nov 1, 2025
There was a problem hiding this comment.
Thanks for this.
As written, the plural form if piped to splain will not find the diag entry. I think it should.
I believe you can achieve that by either having a =item section for both forms (one right after the other) or change this:
=item Unrecognized named parameter '%s' to subroutine '%s'
To this:
=item Unrecognized named parameter%s '%s' to subroutine '%s'
2414522 to
dee8bc5
Compare
Rather than stop immediately at the first failure, we can be a bit more helpful by collecting up potentially multiple names at once. We limit the list to 5 elements, just to limit the potential output in the case of accidentally passing a list of hundreds or thousands of elements into such a function.
leonerd
force-pushed
the
named-parameters-collect-errors
branch
from
dee8bc5 to
b1671d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than stop immediately at the first failure, we can be a bit more helpful by collecting up potentially multiple names at once.
We limit the list to 5 elements, just to limit the potential output in the case of accidentally passing a list of hundreds or thousands of elements into such a function.