grok_bin_oct_hex:Simplify #23901
Open
grok_bin_oct_hex:Simplify #23901
+37
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating an upper limit to parse allows us to write while (s < e) for example, and that limit is constant, requiring fewer operations than the other way, where the remaining length keeps getting changed. It also allows this commit to move an 's++' a couple of lines to get rid of comparing against the number '8' which could get out of sync.
This removes a special case, paving the way for potential future generalizations.
This caused an extra assignment that was then discarded
tonycoz
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major part of this p.r. is to change this function to set an upper limit to parsing. Previously it used the remaining length, which had to be continually adjusted during the parse.