Refactor Fog of War round 2 #1872
Conversation
…ons not showing behind fog if SpySat=yes
…es drawing buildings
- Hide particles under fog for all units, not just enemies - Add exception handling to prevent cursor targeting crashes on fogged buildings - Simplify fog checks using Fog::IsFogged() for consistency
… removed Ebolt debug logging
…oveShroudOnly should still work though
…rlayTypes and TerrainTypes. still to do: objects remain on screen unchanged from fog proxy state
…rmance, and cleanup issues
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
TaranDahl
added
❓Restored feature
|
-Terrain Objects with custom palettes are using theater palette under fog 
|
|
If it really doesn't work, then forget it. Using a smoke shell combined with passive super weapon effects is also quite good. |
|
Tested was in 20XX and MO, error occurred in both mod so all of them are here -Random Mid-Game Crash: The game crashes unexpectedly after 5-10 minutes of gameplay. The error message is Exception code: C0000005 at 0074056E. (Crash dump and related files have been sent via Discord DM) and this problem occurred not only with me but other testers. -Multiplayer Crash: Multiplayer games crash with a breakpoint error approximately 3-5 seconds after the match begins (ERROR_CODE: (NTSTATUS) 0x80000003 - {EXCEPTION} Breakpoint A breakpoint has been reached.). -Friendly Player MCV Animation: The Allied Player MCV is missing its static (None updating) animation frames; only the dynamic (Moving parts) animation is visible. 
-Pre-Captured Tech Buildings: Tech buildings when captured by enemy appear as captured on the map before any player has scouted them. 
-Map Reveal on Large Maps: On large maps, parts of the map remain covered by the Fog of War and part is unexplored/unknown, or the center point of the revealed area seems to be posed (moving in x but not y direction) incorrect. 
-Ore Miner Attack Command: The "attack" cursor indicator disappears when hovering over ore fields with the Ore Miner selected. -Destroyed Bridges in Fog of War: Bridges that are pre-destroyed in the map editor appear as intact when covered by the Fog of War. 
-Engineers and Tech Buildings in Fog of War: Engineers can be ordered to enter a tech building that is under the Fog of War. However, upon reaching the building, the engineer does not enter it. -Inconsistent Selection of Revealed Enemy Buildings: Some enemy buildings remain selectable under the Fog of War after being revealed, while others do not. 
-Crater and Shadow Visual Glitches: Explosion craters are incorrectly rendered on top of buildings. A similar layering issue sometimes occurs with shadows. 
-Incorrect Fence Color After Destruction: When a fence is destroyed, the remaining fence posts change to the player's color. 
-Damaged Buildings Under Fog of War: Occasionally, if a building takes damage while it is under the Fog of War, its visual state in the fog will update to show it as damaged. |
|
@Erjet You might also want to download here a snapshot from the debug folder. It will contain a dmp, debug information, and other information. |
|
Doesn't just "might want", Phobos crash report is useless without dmp. |
|
i have and drop it in DM of ayylmao some hours ago |
|
And last one, some animation are broken (its MO) 
|
7 participants
Picking up the closed PR #530 .
Forward ported the old PR and fixed the following from showing under fog:
Other improvements:
RemoveShroudGloballyto combat the Shroud=no issue belowBuildingType,OverlayTypeandTerrainTypeflickering/vanishing under fogRemoveShroudGlobally
I added this as a way to bypass the Shroud=no issue, it works by removing Shroud at the beginning of the game, while keeping Fog intact. How to use:
Note: this can also be enabled via CnCNet Client configuration
CnCNet Client
In your game/skirmish/multiplayerlobby config, add a GameLobbyCheckBox with:
Still to do:
Ripple.RadiusProduceCashDisplayRefinerySmokeParticleSystemcreated by SlavedInfantryTypesstill shows under fogSevere issues:
RemoveShroudGlobally)Future QOL:
Shroud=noinstead ofRemoveShroudGlobally=yes, a pro will need to look into it.quick.fow.mp4