[Components] linkup api - new components #19032
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdds a LinkUp API integration: new app component with an Axios HTTP wrapper, expanded propDefinitions and public methods, a small utils module, package bump, and ten new action modules for authentication, profile/company lookup, search, messaging, conversations, invitations, and connection requests. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action
participant App
participant LinkUpAPI
User->>Action: Trigger action with props
activate Action
Action->>Action: Read/destructure props
Action->>App: app.<method>({ $, data: {...} })
activate App
App->>App: Build URL & headers (_getHeaders)
App->>LinkUpAPI: HTTP POST with snake_case payload
activate LinkUpAPI
LinkUpAPI-->>App: Return response
deactivate LinkUpAPI
App-->>Action: Return response
deactivate App
Action->>Action: $.export("$summary","...")
Action-->>User: Return response
deactivate Action
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs(1 hunks)components/linkupapi/actions/get-company-info/get-company-info.mjs(1 hunks)components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs(1 hunks)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs(1 hunks)components/linkupapi/actions/get-profile-info/get-profile-info.mjs(1 hunks)components/linkupapi/actions/login/login.mjs(1 hunks)components/linkupapi/actions/search-companies/search-companies.mjs(1 hunks)components/linkupapi/actions/search-profiles/search-profiles.mjs(1 hunks)components/linkupapi/actions/send-message/send-message.mjs(1 hunks)components/linkupapi/actions/verify-code/verify-code.mjs(1 hunks)components/linkupapi/common/utils.mjs(1 hunks)components/linkupapi/linkupapi.app.mjs(1 hunks)components/linkupapi/package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (5)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/linkupapi/package.json
📚 Learning: 2024-10-08T15:33:38.240Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Applied to files:
components/linkupapi/actions/send-message/send-message.mjscomponents/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjscomponents/linkupapi/actions/get-invitations-status/get-invitations-status.mjs
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.
Applied to files:
components/linkupapi/actions/send-message/send-message.mjs
📚 Learning: 2025-06-04T17:52:05.780Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Applied to files:
components/linkupapi/linkupapi.app.mjs
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/linkupapi/linkupapi.app.mjs
🧬 Code graph analysis (10)
components/linkupapi/actions/login/login.mjs (1)
components/linkupapi/actions/verify-code/verify-code.mjs (1)
response(44-51)
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (6)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(81-90)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)components/linkupapi/actions/send-message/send-message.mjs (1)
response(51-59)
components/linkupapi/actions/search-companies/search-companies.mjs (2)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(81-90)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (4)
components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/send-message/send-message.mjs (1)
response(51-59)
components/linkupapi/actions/get-company-info/get-company-info.mjs (3)
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)
components/linkupapi/actions/send-message/send-message.mjs (1)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/send-message/send-message.mjs (1)
response(51-59)
components/linkupapi/actions/verify-code/verify-code.mjs (1)
components/linkupapi/actions/login/login.mjs (1)
response(43-50)
components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
🔇 Additional comments (16)
components/linkupapi/package.json (1)
3-16: LGTM!The version bump to 0.1.0 and the addition of the
@pipedream/platformdependency are appropriate for this new integration.components/linkupapi/common/utils.mjs (1)
1-9: LGTM!The utility function correctly handles optional array properties by joining non-empty arrays with a separator or returning undefined. This aligns with the API payload requirements for actions like search-profiles and search-companies.
components/linkupapi/linkupapi.app.mjs (1)
108-196: LGTM!The HTTP helper methods and API endpoint wrappers follow Pipedream conventions. The consistent pattern of delegating to
postwith appropriate paths makes the code maintainable and easy to extend.components/linkupapi/actions/login/login.mjs (1)
1-56: LGTM!The login action correctly maps props to the API payload and follows Pipedream action conventions. The annotations appropriately reflect that this is a non-destructive, outbound operation.
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
1-57: LGTM!The action correctly retrieves profile information with proper field mapping to the API's snake_case convention. The annotations appropriately indicate this is a read-only, idempotent operation.
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
77-79: LGTM!The validation correctly ensures at least one identifier (LinkedIn URL or Conversation ID) is provided, using the appropriate
ConfigurationErrorfrom the platform.components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
11-16: Verify ifcompanyUrlshould be required.The
companyUrlprop is marked asoptional: true, but the API likely requires it to retrieve company information. Without validation, users may encounter cryptic API errors.Compare with similar actions (e.g.,
get-profile-inforequireslinkedinUrl) and verify the API documentation. If required, apply this diff:companyUrl: { type: "string", label: "Company URL", description: "LinkedIn company URLs. Eg. `https://www.linkedin.com/company/stripe/`", - optional: true, },Alternatively, add validation in the
runmethod if it truly is optional.components/linkupapi/actions/verify-code/verify-code.mjs (1)
1-57: LGTM!The verify-code action correctly implements the verification flow with appropriate props and annotations. The
idempotentHint: falsecorrectly indicates that code verification may have side effects.components/linkupapi/actions/send-message/send-message.mjs (2)
3-35: LGTM!The action metadata and prop definitions are well-structured and consistent with Pipedream patterns. All props correctly reference propDefinitions from the app module.
42-64: LGTM!The run method correctly maps input props to the API payload format and returns the response. The implementation is clean and follows the established pattern.
components/linkupapi/actions/search-companies/search-companies.mjs (2)
4-71: LGTM!The action metadata is well-structured with clear prop definitions. The companySize options are well-defined and match the LinkedIn company size ranges.
83-94: Verify the sector parameter separator against LinkUp API documentation.The inconsistency identified is real:
networkin search-profiles usesutils.getOptionalProp(network, ",")with a comma separator, whilesectorin search-companies usesutils.getOptionalProp(sector)with the default semicolon separator. Both arestring[]types.Check the LinkUp API documentation for the
/companies/searchendpoint to confirm whether thesectorparameter expects comma-separated values (matchingnetwork) or semicolon-separated values (current implementation).components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
3-64: LGTM!The action is well-structured with appropriate annotations for a connection request operation (destructive, non-idempotent). The optional
messageprop is correctly mapped tomessage_textin the API payload.components/linkupapi/actions/search-profiles/search-profiles.mjs (2)
10-99: LGTM!The props are well-defined with clear descriptions. The
networkprop options are particularly well-structured with descriptive labels for LinkedIn connection levels.
106-143: LGTM!The run method correctly maps all search parameters to the API payload format. The use of
utils.getOptionalPropfor array parameters is appropriate, with thenetworkparameter specifically using a comma separator as required by the API.components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
3-56: LGTM!The action is well-structured with appropriate annotations for a read-only status check operation. The annotations correctly indicate this is a non-destructive, idempotent operation.
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs
Outdated
Show resolved
Hide resolved
components/linkupapi/actions/search-profiles/search-profiles.mjs
Outdated
Show resolved
Hide resolved
jcortes
force-pushed
the
linkupapi-new-components
branch
from
d719bcf to
3e68d23
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
components/linkupapi/linkupapi.app.mjs (1)
63-85: Harden conversation dropdown against missing fields
last_messageandparticipantaren’t guaranteed to be present on every conversation (e.g., newly created threads or system items). The current destructuring will throw when either object is missing, which breaks the prop options loader. The docs shownext_cursormay benulland conversations can be paginated, so we should default and guard against absent metadata.- const { - data: { - conversations, - next_cursor, - }, - } = await this.getConversations({ + const { + data: { + conversations = [], + next_cursor = null, + } = {}, + } = await this.getConversations({ data: { login_token: loginToken, next_cursor: prevContext?.nextCursor, }, }); - return { - options: conversations.map(({ - conversation_id: value, - last_message: { text }, - participant: { name }, - }) => ({ - label: `${name || "Unknown"} - ${text?.substring(0, 50) || "No message"}`, - value, - })), - context: { - nextCursor: next_cursor, - }, - }; + return { + options: conversations + .map((conversation = {}) => { + const value = conversation.conversation_id; + if (!value) return null; + + const text = conversation.last_message?.text ?? ""; + const name = conversation.participant?.name ?? "Unknown"; + + return { + label: `${name} - ${text ? text.substring(0, 50) : "No message"}`, + value, + }; + }) + .filter(Boolean), + context: { + nextCursor: next_cursor, + }, + };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs(1 hunks)components/linkupapi/actions/get-company-info/get-company-info.mjs(1 hunks)components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs(1 hunks)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs(1 hunks)components/linkupapi/actions/get-profile-info/get-profile-info.mjs(1 hunks)components/linkupapi/actions/login/login.mjs(1 hunks)components/linkupapi/actions/search-companies/search-companies.mjs(1 hunks)components/linkupapi/actions/search-profiles/search-profiles.mjs(1 hunks)components/linkupapi/actions/send-message/send-message.mjs(1 hunks)components/linkupapi/actions/verify-code/verify-code.mjs(1 hunks)components/linkupapi/common/utils.mjs(1 hunks)components/linkupapi/linkupapi.app.mjs(1 hunks)components/linkupapi/package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2024-07-04T18:11:59.822Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Applied to files:
components/linkupapi/actions/send-message/send-message.mjscomponents/linkupapi/actions/get-invitations-status/get-invitations-status.mjscomponents/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.
Applied to files:
components/linkupapi/actions/send-message/send-message.mjs
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/linkupapi/package.json
📚 Learning: 2025-06-04T17:52:05.780Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Applied to files:
components/linkupapi/linkupapi.app.mjs
📚 Learning: 2025-09-12T07:49:36.125Z
Learnt from: matyascimbulka
Repo: PipedreamHQ/pipedream PR: 18308
File: components/apify/actions/run-task-synchronously/run-task-synchronously.mjs:70-0
Timestamp: 2025-09-12T07:49:36.125Z
Learning: The Apify Task object always contains the `options` field according to the official API documentation, making nested destructuring like `options: { build }` safe to use without additional checks.
Applied to files:
components/linkupapi/linkupapi.app.mjs
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/linkupapi/linkupapi.app.mjs
🧬 Code graph analysis (10)
components/linkupapi/actions/search-profiles/search-profiles.mjs (2)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(69-78)components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)
components/linkupapi/actions/send-message/send-message.mjs (2)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)
components/linkupapi/actions/verify-code/verify-code.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/login/login.mjs (1)
response(43-50)
components/linkupapi/actions/get-company-info/get-company-info.mjs (4)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)
components/linkupapi/actions/search-companies/search-companies.mjs (3)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(69-78)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)components/linkupapi/linkupapi.app.mjs (1)
loginToken(63-73)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (4)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(69-78)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/send-message/send-message.mjs (1)
response(51-59)
components/linkupapi/actions/login/login.mjs (2)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/verify-code/verify-code.mjs (1)
response(44-51)
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (5)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)components/linkupapi/actions/send-message/send-message.mjs (1)
response(51-59)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (4)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)components/linkupapi/actions/send-message/send-message.mjs (1)
response(51-59)components/linkupapi/linkupapi.app.mjs (1)
loginToken(63-73)
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: Verify TypeScript components
🔇 Additional comments (7)
components/linkupapi/package.json (1)
3-3: LGTM!The version bump to 0.1.0 and the addition of the
@pipedream/platformdependency are appropriate for the new LinkUp API actions being introduced in this PR.Also applies to: 15-16
components/linkupapi/common/utils.mjs (1)
1-5: LGTM!The utility function correctly handles optional array props by joining them into a string when present, or returning undefined when absent. The logic is sound and the implementation is clean.
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
3-57: LGTM!The action follows standard Pipedream conventions with appropriate annotations for a read-only profile retrieval operation. The prop wiring, data mapping, and summary export are all correctly implemented.
components/linkupapi/actions/verify-code/verify-code.mjs (1)
3-57: LGTM!The verify code action is correctly structured with appropriate annotations. The
idempotentHint: falseis correct since verification codes are typically consumed upon use, and the summary message appropriately avoids including sensitive information.components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
3-56: LGTM!The action is well-structured with appropriate annotations for a read-only company information retrieval. The inline definition of
companyUrlwith an example is helpful for users.components/linkupapi/actions/send-message/send-message.mjs (1)
3-65: LGTM!The send message action is correctly structured with appropriate annotations. The
destructiveHint: trueandidempotentHint: falsecorrectly reflect the nature of sending messages, and the summary message appropriately avoids including sensitive content.components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
123-139: No action needed—separator choice is correct per LinkUp API specification.The LinkUp API network field requires comma-separated values (example: "F,S,O"), while other multi-value parameters use semicolons. The code correctly implements this requirement by explicitly passing
","for the network parameter while using the default semicolon separator forcompany_url,location, andschool_url.
luancazarine
left a comment
luancazarine
left a comment
There was a problem hiding this comment.
Hi @jcortes, LGTM! Ready for QA!
|
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement. Please check test reports below for more information:
|
jcortes
force-pushed
the
linkupapi-new-components
branch
from
3e68d23 to
a56f125
Compare
|
Hi @vunguyenhung I've just pushed a UX fix for the user when it comes to send a message. The idea is to only be able to send those messages to connected accounts. Please test with latest change. Thanks! |
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (3)
components/linkupapi/linkupapi.app.mjs (1)
53-87: HardenconversationIdoptions against missing fields (deep destructuring can throw)The options loader assumes
data.conversationsalways exists and that each item haslast_messageandparticipant. If the API schema changes or a field is missing, this will throw at destructuring time and break the prop UI.You can make this defensive by defaulting
data/conversationsand the nested fields:- const { - data: { - conversations, - next_cursor, - }, - } = await this.getConversations({ + const { + data: { + conversations = [], + next_cursor, + } = {}, + } = await this.getConversations({ data: { login_token: loginToken, next_cursor: prevContext?.nextCursor, }, }); return { - options: conversations.map(({ - conversation_id: value, - last_message: { text }, - participant: { name }, - }) => ({ - label: `${name || "Unknown"} - ${text?.substring(0, 50) || "No message"}`, - value, - })), + options: conversations.map(({ + conversation_id: value, + last_message: { text } = {}, + participant: { name } = {}, + }) => ({ + label: `${name || "Unknown"} - ${text?.substring(0, 50) || "No message"}`, + value, + })), context: { nextCursor: next_cursor, }, };This prevents runtime errors when any of these fields are absent while still producing sensible labels.
components/linkupapi/actions/login/login.mjs (1)
30-34: Add missing idempotentHint annotation.The annotations block is missing the
idempotentHintproperty. Login operations generate new session tokens on each call, so this should be set tofalse.Apply this diff:
annotations: { readOnlyHint: false, destructiveHint: false, openWorldHint: true, + idempotentHint: false, },components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
51-59: Fix payload key for optional message.The connection request endpoint expects the optional note under the
messagefield, notmessage_text. Using the wrong key causes the message to be silently dropped.Apply this diff:
const response = await app.connectToProfile({ $, data: { linkedin_url: linkedinUrl, login_token: loginToken, - message_text: message, + ...(message && { message }), country, }, });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs(1 hunks)components/linkupapi/actions/get-company-info/get-company-info.mjs(1 hunks)components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs(1 hunks)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs(1 hunks)components/linkupapi/actions/get-profile-info/get-profile-info.mjs(1 hunks)components/linkupapi/actions/login/login.mjs(1 hunks)components/linkupapi/actions/search-companies/search-companies.mjs(1 hunks)components/linkupapi/actions/search-profiles/search-profiles.mjs(1 hunks)components/linkupapi/actions/send-message/send-message.mjs(1 hunks)components/linkupapi/actions/verify-code/verify-code.mjs(1 hunks)components/linkupapi/common/utils.mjs(1 hunks)components/linkupapi/linkupapi.app.mjs(1 hunks)components/linkupapi/package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2024-10-08T15:33:38.240Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Applied to files:
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjscomponents/linkupapi/actions/send-message/send-message.mjs
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/linkupapi/package.json
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.
Applied to files:
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjscomponents/linkupapi/actions/send-message/send-message.mjs
📚 Learning: 2025-06-04T17:52:05.780Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Applied to files:
components/linkupapi/linkupapi.app.mjs
📚 Learning: 2025-09-12T07:49:36.125Z
Learnt from: matyascimbulka
Repo: PipedreamHQ/pipedream PR: 18308
File: components/apify/actions/run-task-synchronously/run-task-synchronously.mjs:70-0
Timestamp: 2025-09-12T07:49:36.125Z
Learning: The Apify Task object always contains the `options` field according to the official API documentation, making nested destructuring like `options: { build }` safe to use without additional checks.
Applied to files:
components/linkupapi/linkupapi.app.mjs
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/linkupapi/linkupapi.app.mjs
🧬 Code graph analysis (9)
components/linkupapi/actions/get-company-info/get-company-info.mjs (4)
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (5)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)components/linkupapi/actions/send-message/send-message.mjs (1)
response(58-66)components/linkupapi/linkupapi.app.mjs (1)
loginToken(63-73)
components/linkupapi/actions/login/login.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/verify-code/verify-code.mjs (1)
response(44-51)
components/linkupapi/actions/search-profiles/search-profiles.mjs (2)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(69-78)components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (2)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (4)
components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/send-message/send-message.mjs (1)
response(58-66)
components/linkupapi/actions/verify-code/verify-code.mjs (1)
components/linkupapi/actions/login/login.mjs (1)
response(43-50)
components/linkupapi/actions/send-message/send-message.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)
components/linkupapi/actions/search-companies/search-companies.mjs (1)
components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: Ensure component commits modify component versions
🔇 Additional comments (11)
components/linkupapi/package.json (1)
3-17: Package metadata bump looks consistentVersion
0.1.0and the added dependency align with the new LinkUp app methods and actions; no issues from this change alone.components/linkupapi/linkupapi.app.mjs (1)
107-197: Shared HTTP wrapper and endpoint methods look coherent
getUrl,_getHeaders,_makeRequest, and the small POST helpers provide a clear, consistent surface for all LinkUp endpoints, and the path mappings match the action intents.Based on learnings
components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
106-143: Profile search payload wiring looks correctThe action cleanly maps props to the
searchProfilespayload, and usingutils.getOptionalPropfor the array filters (company URL, location, school URL, network) is consistent and keeps the request shape compact.Based on learnings
components/linkupapi/actions/search-companies/search-companies.mjs (1)
1-99: LGTM!The action is well-structured with complete annotations, proper use of
utils.getOptionalPropfor optional array props, and all props correctly mapped to the API payload.components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
1-56: LGTM!The action correctly handles the optional
companyUrlparameter and has complete annotations. The implementation aligns with other actions in this PR.components/linkupapi/actions/send-message/send-message.mjs (1)
1-78: LGTM!The action includes helpful user guidance via the info alert and provides good error handling with a user-friendly message for the invalid parameter case.
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
1-57: LGTM!The action follows the standard pattern with complete annotations and correct prop mapping to the API payload.
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
1-57: LGTM!The action follows the standard pattern with complete annotations and correct prop mapping to the API payload.
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (3)
1-2: LGTM!The imports are correct and both are used appropriately in the action.
4-9: LGTM!The action metadata is well-structured and follows Pipedream conventions.
50-55: LGTM!The annotations accurately describe the action's behavior: read-only, non-destructive, makes external calls, and is idempotent.
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs
Show resolved
Hide resolved
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
jcortes
force-pushed
the
linkupapi-new-components
branch
from
a56f125 to
2523b14
Compare
|
/approve |
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (7)
components/linkupapi/common/utils.mjs (1)
1-5: Past review comment applies.A previous review suggested making
getOptionalProphandle both arrays and scalar values defensively for future-proofing. The current implementation is correct for existing usage.components/linkupapi/actions/verify-code/verify-code.mjs (1)
53-53: Past review comment applies.The summary message "Successfully verified code for email" was flagged in a previous review as incomplete. Consider either removing "for email" or interpolating the actual email address.
components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
81-86: Past review comment applies.A previous review noted that the
totalResultsprop description claims a default of 10, but no explicitdefaultvalue is set on the prop. Consider addingdefault: 10or removing the default mention from the description.components/linkupapi/actions/login/login.mjs (1)
30-34: Past review comment applies.A previous review noted that the
idempotentHintproperty is missing from the annotations block. Since login operations generate new session tokens on each call, this should be set tofalse.components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
51-58: Fix payload key for optional messageThe LinkUp "Send Connection Request" endpoint expects the optional note under the
messagefield, notmessage_text. Sending the wrong key causes the message to be dropped even though the request succeeds.Apply this diff to fix the payload key:
const response = await app.connectToProfile({ $, data: { linkedin_url: linkedinUrl, login_token: loginToken, - message_text: message, country, + ...(message && { message }), }, });components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
37-42: Clarify or set the default value for totalResults.The description mentions "(default: 10)" but no default value is set in the prop definition. If the API defaults to 10 when the parameter is omitted, this is fine but the description is misleading. If you intend for this prop to default to 10 on the client side, add
default: 10.Apply this diff if the default should be 10:
totalResults: { type: "integer", label: "Total Results", description: "Number of messages to retrieve when not in pagination mode (default: 10)", optional: true, + default: 10, },Otherwise, remove the "(default: 10)" text from the description.
components/linkupapi/linkupapi.app.mjs (1)
63-86: Add safe property access for nested destructuring.The code destructures deeply nested properties without safeguards. If the API response structure differs from expectations (e.g., missing
conversations,last_message, orparticipantfields), this will cause runtime errors.Apply this diff to add safe property access:
const { data: { - conversations, - next_cursor, - }, + conversations = [], + next_cursor = null, + } = {}, } = await this.getConversations({ data: { login_token: loginToken, next_cursor: prevContext?.nextCursor, }, }); return { options: conversations.map(({ conversation_id: value, - last_message: { text }, - participant: { name }, + last_message: { text } = {}, + participant: { name } = {}, }) => ({ label: `${name || "Unknown"} - ${text?.substring(0, 50) || "No message"}`, value, })),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (13)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs(1 hunks)components/linkupapi/actions/get-company-info/get-company-info.mjs(1 hunks)components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs(1 hunks)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs(1 hunks)components/linkupapi/actions/get-profile-info/get-profile-info.mjs(1 hunks)components/linkupapi/actions/login/login.mjs(1 hunks)components/linkupapi/actions/search-companies/search-companies.mjs(1 hunks)components/linkupapi/actions/search-profiles/search-profiles.mjs(1 hunks)components/linkupapi/actions/send-message/send-message.mjs(1 hunks)components/linkupapi/actions/verify-code/verify-code.mjs(1 hunks)components/linkupapi/common/utils.mjs(1 hunks)components/linkupapi/linkupapi.app.mjs(1 hunks)components/linkupapi/package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (7)
📚 Learning: 2024-10-08T15:33:38.240Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Applied to files:
components/linkupapi/actions/verify-code/verify-code.mjscomponents/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjscomponents/linkupapi/actions/send-message/send-message.mjscomponents/linkupapi/actions/get-invitations-status/get-invitations-status.mjs
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/linkupapi/package.json
📚 Learning: 2025-07-01T17:07:48.193Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.193Z
Learning: For "dir" props in Pipedream components, whether to mark them as optional depends on the action's file I/O behavior - if an action always writes files as output, the "dir" prop should not be marked as optional.
Applied to files:
components/linkupapi/common/utils.mjs
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.
Applied to files:
components/linkupapi/actions/send-message/send-message.mjscomponents/linkupapi/actions/connect-to-profile/connect-to-profile.mjs
📚 Learning: 2025-06-04T17:52:05.780Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Applied to files:
components/linkupapi/linkupapi.app.mjs
📚 Learning: 2025-09-12T07:49:36.125Z
Learnt from: matyascimbulka
Repo: PipedreamHQ/pipedream PR: 18308
File: components/apify/actions/run-task-synchronously/run-task-synchronously.mjs:70-0
Timestamp: 2025-09-12T07:49:36.125Z
Learning: The Apify Task object always contains the `options` field according to the official API documentation, making nested destructuring like `options: { build }` safe to use without additional checks.
Applied to files:
components/linkupapi/linkupapi.app.mjs
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/linkupapi/linkupapi.app.mjs
🧬 Code graph analysis (10)
components/linkupapi/actions/verify-code/verify-code.mjs (1)
components/linkupapi/actions/login/login.mjs (1)
response(43-50)
components/linkupapi/actions/login/login.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/send-message/send-message.mjs (1)
response(58-66)components/linkupapi/actions/verify-code/verify-code.mjs (1)
response(44-51)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (8)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)components/linkupapi/actions/send-message/send-message.mjs (1)
response(58-66)components/linkupapi/linkupapi.app.mjs (1)
loginToken(63-73)
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (5)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(69-78)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/send-message/send-message.mjs (1)
response(58-66)
components/linkupapi/actions/send-message/send-message.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (3)
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/send-message/send-message.mjs (1)
response(58-66)
components/linkupapi/actions/get-company-info/get-company-info.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)
components/linkupapi/actions/search-companies/search-companies.mjs (2)
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs (1)
response(69-78)components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
response(123-139)
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (3)
components/linkupapi/actions/connect-to-profile/connect-to-profile.mjs (1)
response(51-59)components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
response(44-51)components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
response(44-51)
components/linkupapi/actions/search-profiles/search-profiles.mjs (1)
components/linkupapi/actions/search-companies/search-companies.mjs (1)
response(83-94)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
🔇 Additional comments (6)
components/linkupapi/package.json (1)
3-3: LGTM!The version bump to 0.1.0 and the addition of the
@pipedream/platformdependency are appropriate for this new component integration.Also applies to: 15-17
components/linkupapi/actions/get-company-info/get-company-info.mjs (1)
1-56: LGTM!The action is well-structured with proper propDefinitions, appropriate annotations (including
idempotentHint: truefor this read operation), and follows the established pattern for LinkUp API actions.components/linkupapi/actions/send-message/send-message.mjs (1)
11-16: LGTM!The informational alert and enhanced error handling provide excellent user experience by clearly communicating prerequisites and providing helpful error messages when the connection requirement isn't met.
Also applies to: 57-76
components/linkupapi/actions/get-profile-info/get-profile-info.mjs (1)
1-57: LGTM!The action follows the established pattern correctly. Props are wired appropriately, the payload mapping uses the correct snake_case keys, and the annotations accurately reflect a read-only, idempotent operation.
components/linkupapi/actions/get-invitations-status/get-invitations-status.mjs (1)
1-57: LGTM!The action is well-structured and follows the established pattern. The payload mapping is correct, and the annotations appropriately reflect a read-only, idempotent operation.
components/linkupapi/linkupapi.app.mjs (1)
108-197: HTTP wrapper and endpoint methods are well-structured.The centralized HTTP request handling with
_makeRequestand the endpoint-specific methods follow Pipedream's established patterns correctly. The header injection and URL construction are implemented properly.
| async run({ $ }) { | ||
| const { | ||
| loginToken, | ||
| linkedinUrl, | ||
| conversationId, | ||
| totalResults, | ||
| country, | ||
| } = this; | ||
|
|
||
| if (!linkedinUrl && !conversationId) { | ||
| throw new ConfigurationError("Either **LinkedIn URL** or **Conversation ID** is required"); | ||
| } | ||
|
|
||
| const response = await this.app.getConversationMessages({ | ||
| $, | ||
| data: { | ||
| login_token: loginToken, | ||
| linkedin_url: linkedinUrl, | ||
| conversation_id: conversationId, | ||
| country, | ||
| total_results: totalResults, | ||
| }, | ||
| }); | ||
|
|
||
| $.export("$summary", "Successfully retrieved conversation messages"); | ||
| return response; | ||
| }, |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Good validation logic.
The either/or validation for linkedinUrl and conversationId is well-implemented and provides a clear error message.
Optionally, consider enhancing the summary message with the count of messages returned (e.g., Successfully retrieved ${response.messages?.length || 0} conversation message(s)) if the API response includes a message count. Based on learnings.
🤖 Prompt for AI Agents
In
components/linkupapi/actions/get-conversation-messages/get-conversation-messages.mjs
around lines 56 to 82, improve the exported summary to include the number of
messages returned by the API; after receiving response, compute a safe count
like const count = response?.messages?.length ?? 0 and change the
$.export("$summary", ...) call to use that count (e.g., "Successfully retrieved
X conversation message(s)"), ensuring optional chaining/nullish coalescing is
used so undefined responses don't throw.
| totalResults: { | ||
| type: "integer", | ||
| label: "Total Results", | ||
| description: "Number of companies to retrieve when not in pagination mode (default: 10)", | ||
| optional: true, | ||
| }, |
There was a problem hiding this comment.
Align description with implementation for totalResults default.
The description states "(default: 10)" but the prop has no explicit default value, so the effective default depends on the API behavior. Either add default: 10 to the prop definition or remove the default mention from the description.
Apply this diff to add an explicit default:
totalResults: {
type: "integer",
label: "Total Results",
- description: "Number of companies to retrieve when not in pagination mode (default: 10)",
+ description: "Number of companies to retrieve when not in pagination mode",
optional: true,
+ default: 10,
},Or remove the default mention:
totalResults: {
type: "integer",
label: "Total Results",
- description: "Number of companies to retrieve when not in pagination mode (default: 10)",
+ description: "Number of companies to retrieve when not in pagination mode",
optional: true,
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| totalResults: { | |
| type: "integer", | |
| label: "Total Results", | |
| description: "Number of companies to retrieve when not in pagination mode (default: 10)", | |
| optional: true, | |
| }, | |
| totalResults: { | |
| type: "integer", | |
| label: "Total Results", | |
| description: "Number of companies to retrieve when not in pagination mode", | |
| optional: true, | |
| default: 10, | |
| }, |
🤖 Prompt for AI Agents
In components/linkupapi/actions/search-companies/search-companies.mjs around
lines 53 to 58, the prop `totalResults` description mentions a "(default: 10)"
but no explicit `default` is set; either add `default: 10` to the prop
definition or remove the default mention from the description. To fix, update
the prop block to include `default: 10` if you intend to enforce a client-side
default, or edit the description to remove "(default: 10)" so it matches
API-driven behavior.
WHY
Resolves #18894
Summary by CodeRabbit
New Features
Chores