Fix regression to allow custom value conversion mapping when the ClrType is of non-NTS type. plus added unit test. #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 31, 2024 09:17
…ype is of non-NTS type. plus added unit test. - regression introduced in commit [3ef628f](PomeloFoundation@3ef628f#diff-4f1d25d8c94e4764d1beef032d7ecc17efaf6a2f592db3dab748bac1d7fc0446R87) Refs PomeloFoundation#1921
…rlier conversion of custom mapping fix. - The Geometry column mapping issue is caused when the storeTypeName is null as a result of user's not specifying `.HasColumnType()` in their entity configuration. - We still cannot use defaultStoreType when storeTypeName is null because then we cannot do custom value conversion such as mapping non-NTS types (byte[]) to NTS geometry types as was intended with the previous commits. See PomeloFoundation#1921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression to allow custom value conversion mapping when the ClrType is of non-NTS type. plus added unit test.
Refs #1921
Also updates
System.Text.Jsonpackage to resolve CVE-2024-30105.