Skip to content

Conversation

@hpouillot
Copy link
Contributor

@hpouillot hpouillot commented Dec 19, 2025

Related: https://posthoghelp.zendesk.com/agent/tickets/45477

add in_app_modules config option

@hpouillot hpouillot marked this pull request as ready for review December 19, 2025 13:59
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (4)

  1. posthog/__init__.py, line 213 (link)

    syntax: The type annotation Optional[list[str]] uses Python 3.9+ syntax. For backward compatibility with Python 3.8 and earlier versions, should use Optional[List[str]] from the typing module instead.

  2. posthog/client.py, line 190 (link)

    syntax: The type annotation list[str] | None uses Python 3.10+ syntax. For backward compatibility, use Optional[List[str]] from the typing module instead.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  3. posthog/client.py, line 192-209 (link)

    style: Missing documentation for the new in_app_modules parameter in the docstring.

    Add documentation explaining what this parameter does and how to use it, consistent with other parameters like capture_exception_code_variables, code_variables_mask_patterns, and code_variables_ignore_patterns.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  4. posthog/__init__.py, line 213 (link)

    style: Missing documentation comment explaining what in_app_modules does. Other global configuration variables in this file have explanatory comments or docstrings (e.g., capture_exception_code_variables, code_variables_mask_patterns, code_variables_ignore_patterns).

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

5 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@hpouillot hpouillot merged commit 7ac63e1 into master Dec 22, 2025
15 checks passed
@hpouillot hpouillot deleted the err/in_app_configuration branch December 22, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants