update lxml dependency #1097
Merged
update lxml dependency #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Very strangely, it seems like using lxml v6 breaks having path names with spaces in them. I don't understand why. I'll hold off this fix until I can get that sorted out. |
Member
Author
|
This turned out to be a codechat issue. Seems that switching to |
Member
Author
|
Ended up removing the tests that match up DEMO_MAPPING anyway for now. It seems like this hasn't been working for a while; I need to figure out the best way forward at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work with windows and python 3.14, we should use lxml v6.x.